Emit warning when there is no space between -o and arg
#143719
Conversation
rustbot
added
A-run-make
|
This PR modifies cc @jieyouxu |
There was a problem hiding this comment.
This seems reasonable, though I can imagine this might be a bit annoying. I'll defer to @wesleywiser for a second opinion.
|
r? @wesleywiser (re. #142812) |
|
|
|
Ah right. I'll wait a bit in case Wesley has feedback. |
| // To avoid confusion, emit warning if no space | ||
| // between `-o` and arg, e.g.`-optimize`, is applied, see issue #142812 | ||
| if let Some(name) = matches.opt_str("o") { | ||
| if args.iter().any(|arg| arg.starts_with("-o") && !arg.starts_with("-o=") && arg.ne("-o")) { | ||
| early_dcx.early_warn(format!("option `-o {}` is applied", name)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggestion: if we're going to emit this warning, can you also include a bit more context on why this is warned on in the first place and how users can address this warning? I.e. for the wording, I suggest
warning: option `-o` has no space between flag name and value, which can be confusing
help: option `-o {}` is applied instead of a flag named `o{}`
help: if you meant to specify output filename `{}`, write `-o {}` instead
There was a problem hiding this comment.
Suggestion: also, maybe remark this case in the rustc book on compiler flags.
There was a problem hiding this comment.
Good suggestions, I will finish this later.
There was a problem hiding this comment.
You might want to hold off on changing this for a moment, still discussing formulation of this warning in the linked thread
|
Asking for some more opinions about if warning on cf. #t-compiler > Warn on `-ofilename`/`-Lpath` without space @rustbot label: -S-waiting-on-review +S-waiting-on-team |
rustbot
added
S-waiting-on-team
|
Now, it prints like this $ rustc +stage1 src/main.rs -optimize
warning: option `-o` has no space between flag name and value, which can be confusing
note: option `-o ptimize` is applied instead of a flag named `optimize` to specify output filename `ptimize`
$ rustc +stage1 src/main.rs -out-dir
warning: option `-o` has no space between flag name and value, which can be confusing
note: option `-o ut-dir` is applied instead of a flag named `out-dir` to specify output filename `ut-dir`
note: Do you mean `--out-dir`?
$ rustc +stage1 src/main.rs -overflow-checks
warning: option `-o` has no space between flag name and value, which can be confusing
note: option `-o verflow-checks` is applied instead of a flag named `overflow-checks` to specify output filename `verflow-checks`
note: Do you mean `-C overflow_checks`?
$ rustc +stage1 src/main.rs -overflow_checks
warning: option `-o` has no space between flag name and value, which can be confusing
note: option `-o verflow_checks` is applied instead of a flag named `overflow_checks` to specify output filename `verflow_checks`
note: Do you mean `-C overflow_checks`?
$ rustc +stage1 src/main.rs -o3
warning: option `-o` has no space between flag name and value, which can be confusing
note: option `-o 3` is applied instead of a flag named `o3` to specify output filename `3`
|
rustbot
added
the
S-waiting-on-review
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
jieyouxu
removed
the
S-waiting-on-team
Closes #142812
getoptdoesn't seem to have an API to check this, so we have to check the args manually.r? compiler