-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[rustdoc-json] Add tests for #[doc(hidden)]
handling of items.
#143665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
These commits modify Please ensure that if you've changed the output:
|
0dfd729
to
083b572
Compare
Removed the HTML test changes, only including the rustdoc JSON tests. |
#[doc(hidden)]
handling of items.#[doc(hidden)]
handling of items.
Thanks for writing these, really appreciate you doing the not glamours (but very important) work here. Tests content is good, but I don't think they should live in Also, could you edit the commit message to make it clear that this is specifically for rustdoc-json. r=me with those nits addressed. @bors delegate+ @bors rollup=always |
✌️ @obi1kenobi, you can now approve this pull request! If @aDotInTheVoid told you to " |
083b572
to
27fb02c
Compare
@bors r=aDotInTheVoid |
…aDotInTheVoid [rustdoc-json] Add tests for `#[doc(hidden)]` handling of items. Add tests which check: - `#[doc(hidden)]` items are not present in rustdoc JSON output by default. - Invoking rustdoc with `--document-hidden-items` makes `#[doc(hidden)]` items appear, and they show their `#[doc(hidden)]` status appropriately. r? `@aDotInTheVoid`
Add tests which check:
#[doc(hidden)]
items are not present in rustdoc JSON output by default.--document-hidden-items
makes#[doc(hidden)]
items appear, and they show their#[doc(hidden)]
status appropriately.r? @aDotInTheVoid