Rollup of 8 pull requests #143459

matthiaskrgr · 2025-07-04T22:12:13Z

Successful merges:

std: sys: net: uefi: tcp4: Implement write #141532 (std: sys: net: uefi: tcp4: Implement write)
Port #[non_exhaustive] to the new attribute parsing infrastructure #143085 (Port #[non_exhaustive] to the new attribute parsing infrastructure)
Remove names_imported_by_glob_use query. #143372 (Remove names_imported_by_glob_use query.)
Assign dependency bump PRs to me #143386 (Assign dependency bump PRs to me)
Remove some unnecessary unsafe in VecCache #143406 (Remove some unnecessary unsafe in VecCache)
mbe: Gracefully handle macro rules that end after => #143408 (mbe: Gracefully handle macro rules that end after =>)
remove special-casing of boxes from match exhaustiveness/usefulness analysis #143414 (remove special-casing of boxes from match exhaustiveness/usefulness analysis)
clean up GVN TypeId test #143444 (clean up GVN TypeId test)

r? @ghost
@rustbot modify labels: rollup

Add a test for various cases of invalid macro definitions. Closes: rust-lang#143351

This removes special-casing of boxes from `rustc_pattern_analysis`, as a first step in replacing `box_patterns` with `deref_patterns`. Incidentally, it fixes a bug caused by box patterns being represented as structs rather than pointers, where `exhaustive_patterns` could generate spurious `unreachable_patterns` lints on arms required for exhaustiveness; following the lint's advice would result in an error.

A blocking implementation of tcp4 write. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

std: sys: net: uefi: tcp4: Implement write A blocking implementation of tcp4 write.

…ser, r=jdonszelmann Port `#[non_exhaustive]` to the new attribute parsing infrastructure Ports `non_exhaustive` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? ``@jdonszelmann``

…nkov Remove names_imported_by_glob_use query. Based on rust-lang#143247 r? ``@ghost`` for perf

…errors Assign dependency bump PRs to me These PRs sometimes get lost as GH reduces their visibility, so I wanted to get an assignment so I can help these PRs land

…r=compiler-errors Remove some unnecessary `unsafe` in VecCache I'm pretty sure, but until perf confirms, r? ghost

…piler-errors mbe: Gracefully handle macro rules that end after `=>` Add a test for various cases of invalid macro definitions. Closes: rust-lang#143351

…adrieril remove special-casing of boxes from match exhaustiveness/usefulness analysis As a first step in replacing `box_patterns` with `deref_patterns`, this treats box patterns as deref patterns in the THIR and exhaustiveness analysis. This allows a bunch of special-casing to be removed. The emitted MIR is unchanged. Incidentally, this fixes a bug caused by box patterns being treated like structs rather than pointers, where enabling `exhaustive_patterns` (rust-lang#51085) could give rise to spurious `unreachable_patterns` lints on arms required for exhaustiveness. Following the lint's advice to remove the match arm would result in an error. I'm not sure what the current state of `exhaustive_patterns` is with regard to reference/box opsem, or whether there's any intention to have `unreachable_patterns` be more granular than the whole arm, but regardless this should hopefully make them easier to handle consistently. Tracking issue for deref patterns: rust-lang#87121 r? `@Nadrieril`

clean up GVN TypeId test addresses rust-lang#142789 (comment) This is an attempt to clarify what this test is actually supposed to test and make it less dependent on `TypeId` internals (it now depends on the output of `type_name` instead). I verified that this version still miscompiles on `nightly-2025-02-11`. r? ``@oli-obk`` ``@RalfJung``

matthiaskrgr · 2025-07-04T22:12:30Z

@bors r+ rollup=never p=5

bors · 2025-07-04T22:12:33Z

📌 Commit 1ff6e44 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-07-04T22:36:42Z

⌛ Testing commit 1ff6e44 with merge d98a5da...

bors · 2025-07-05T01:36:02Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing d98a5da to master...

rust-timer · 2025-07-05T01:38:18Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#141532	std: sys: net: uefi: tcp4: Implement write	`4f7e51470394d588b11a59aafebb0ee8657eb465` (link)
#143085	Port `#[non_exhaustive]` to the new attribute parsing infra…	`2318ed4fb6f48123e458098138846e700237a224` (link)
#143372	Remove names_imported_by_glob_use query.	`141301c9ea15073f57b680fa4e43655fe2621c94` (link)
#143386	Assign dependency bump PRs to me	`5c59e7e9d2a31adec2423a5d821e256b91c200a7` (link)
#143406	Remove some unnecessary `unsafe` in VecCache	`f19e4ca5904271a215dfe544ee583b1ba80275d0` (link)
#143408	mbe: Gracefully handle macro rules that end after `=>`	`714fedd640bdf605182e422703a96d7e411866e1` (link)
#143414	remove special-casing of boxes from match exhaustiveness/us…	`93acf531ca47c751a6bb47a37114377c931122ca` (link)
#143444	clean up GVN TypeId test	`1c59fdc72d736bcd09157a7227ae2584fb634514` (link)

previous master: e3843659e9

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-07-05T01:38:53Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e384365 (parent) -> d98a5da (this PR)

Test differences

Show 16 test diffs

Stage 1

[mir-opt] tests/mir-opt/gvn_const_eval_polymorphic.rs: [missing] -> pass (J2)
[mir-opt] tests/mir-opt/gvn_type_id_polymorphic.rs: pass -> [missing] (J2)
[ui] tests/ui/parser/macro/bad-macro-definition.rs: [missing] -> pass (J2)

Stage 2

[mir-opt] tests/mir-opt/gvn_const_eval_polymorphic.rs: [missing] -> pass (J0)
[mir-opt] tests/mir-opt/gvn_type_id_polymorphic.rs: pass -> [missing] (J0)
[ui] tests/ui/parser/macro/bad-macro-definition.rs: [missing] -> pass (J1)

Additionally, 10 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d98a5da813da67eb189387b8ccfb73cf481275d8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 4657.6s -> 3289.8s (-29.4%)
dist-x86_64-apple: 8033.9s -> 9374.7s (16.7%)
i686-gnu-1: 8311.5s -> 7222.2s (-13.1%)
i686-gnu-2: 6030.6s -> 5327.6s (-11.7%)
x86_64-gnu-llvm-20-1: 3715.0s -> 3294.4s (-11.3%)
dist-apple-various: 5954.3s -> 6520.7s (9.5%)
i686-gnu-nopt-1: 7951.3s -> 7204.5s (-9.4%)
x86_64-gnu-miri: 5023.6s -> 4559.1s (-9.2%)
x86_64-gnu-debug: 5769.0s -> 5257.7s (-8.9%)
x86_64-gnu-llvm-20-2: 6021.2s -> 5505.1s (-8.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-05T04:29:15Z

Finished benchmarking commit (d98a5da): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.5%, secondary -3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.9%, 1.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	-0.5%	[-2.8%, 1.9%]	2

Cycles

Results (secondary 1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[0.4%, 5.9%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.7%	[-2.7%, -0.8%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 460.645s -> 460.925s (0.06%)
Artifact size: 372.20 MiB -> 372.16 MiB (-0.01%)

scottmcm and others added 16 commits July 3, 2025 17:42

Remove some unnecessary unsafe in VecCache

15286f2

mbe: Gracefully handle macro rules that end after =>

0403990

Add a test for various cases of invalid macro definitions. Closes: rust-lang#143351

Assign dependency bump PRs to me

b33dc21

Remove names_imported_by_glob_use query.

2d3ff91

std: sys: net: uefi: tcp4: Implement write

f4ef1a7

A blocking implementation of tcp4 write. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

clean up GVN TypeId test

71176a2

Port #[non_exhaustive] to the new attribute parsing infrastructure

027126c

Rollup merge of rust-lang#141532 - Ayush1325:uefi-tcp4-send, r=tgross35

edfaaeb

std: sys: net: uefi: tcp4: Implement write A blocking implementation of tcp4 write.

Rollup merge of rust-lang#143085 - JonathanBrouwer:non_exhaustive_par…

afe8ee3

…ser, r=jdonszelmann Port `#[non_exhaustive]` to the new attribute parsing infrastructure Ports `non_exhaustive` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? ``@jdonszelmann``

Rollup merge of rust-lang#143372 - cjgillot:bare-glob-map, r=petroche…

031bf97

…nkov Remove names_imported_by_glob_use query. Based on rust-lang#143247 r? ``@ghost`` for perf

Rollup merge of rust-lang#143386 - clubby789:dep-bump-me, r=compiler-…

e2e72cd

…errors Assign dependency bump PRs to me These PRs sometimes get lost as GH reduces their visibility, so I wanted to get an assignment so I can help these PRs land

Rollup merge of rust-lang#143406 - scottmcm:did-we-need-that-unsafe, …

567c51d

…r=compiler-errors Remove some unnecessary `unsafe` in VecCache I'm pretty sure, but until perf confirms, r? ghost

Rollup merge of rust-lang#143408 - joshtriplett:fix-mbe-parser, r=com…

2cde070

…piler-errors mbe: Gracefully handle macro rules that end after `=>` Add a test for various cases of invalid macro definitions. Closes: rust-lang#143351

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2025

bors mentioned this pull request Jul 5, 2025

Block SIMD in transmute_immediate; delete OperandValueKind #143410

Open

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 5, 2025

bors merged commit d98a5da into rust-lang:master Jul 5, 2025
12 checks passed

rustbot added this to the 1.90.0 milestone Jul 5, 2025

This was referenced Jul 5, 2025

Port #[ignore] to the new attribute parsing infrastructure #143238

Open

Port several linking (linkage?) related attributes the new attribute system #143402

Open

Port several trait/coherence-related attributes the new attribute system #143403

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 8 pull requests #143459

Rollup of 8 pull requests #143459

matthiaskrgr commented Jul 4, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Jul 4, 2025

Uh oh!

bors commented Jul 4, 2025

Uh oh!

bors commented Jul 4, 2025

Uh oh!

bors commented Jul 5, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 5, 2025

Uh oh!

github-actions bot commented Jul 5, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Jul 5, 2025

Uh oh!

Uh oh!

Rollup of 8 pull requests #143459

Rollup of 8 pull requests #143459

Conversation

matthiaskrgr commented Jul 4, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Jul 4, 2025

Uh oh!

bors commented Jul 4, 2025

Uh oh!

bors commented Jul 4, 2025

Uh oh!

bors commented Jul 5, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 5, 2025

Uh oh!

github-actions bot commented Jul 5, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jul 5, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

matthiaskrgr commented Jul 4, 2025 •

edited by rustbot

Loading