tests: Don't check for self-printed output in std-backtrace.rs test #143401
+2
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
|
For the record I'm also fine with removing all "stack backtrace" checks if that is what my reviewer prefers. |
davidtwco
approved these changes
Jul 8, 2025
davidtwco
added
S-waiting-on-author
The `Display` implementation for `Backtrace` used to print
stack backtrace:
but that print was later removed. To make the existing test pass, the
print was added to the existing test. But it doesn't make sense to check
for something that the test itself does since that will not detect any
regressions in the implementation of `Backtrace`. Fully remove the
checks.
Enselic
force-pushed
the
no-stack-backtrace-print-in-display
branch
from
715362b to
54cc45d
Compare
|
I completely agree. I wasn't sure what my (then unknown) reviewer would think though so I went with the most defensive correction. (I'm only part of wg-triage so I can't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Displayimplementation forBacktraceused to printbut that print was since removed. See rust-lang/backtrace-rs#286 and #69042. To make the existing test pass, the print was added to the test instead. But it doesn't make sense to check for something that the test itself does since that will not detect any regressions in the implementation of
Backtrace.What the test should check is that "stack backtrace:" is not printed in
DisplayofBacktrace. So do that instead.This is one small steps towards resolving #71706. The next steps after this step involves extending and hardening that test further.