Rollup of 6 pull requests #143363

jdonszelmann · 2025-07-03T11:29:40Z

Successful merges:

setup typos check in CI #134006 (setup typos check in CI)
Port #[target_feature] to new attribute parsing infrastructure #142876 (Port #[target_feature] to new attribute parsing infrastructure)
avoid suggesting traits from private dependencies #143038 (avoid suggesting traits from private dependencies)
Fix rustdoc not correctly showing attributes on re-exports #143083 (Fix rustdoc not correctly showing attributes on re-exports)
document optional jobs #143283 (document optional jobs)
minicore: use core's diagnostic::on_unimplemented messages #143329 (minicore: use core's diagnostic::on_unimplemented messages)

Failed merges:

Port #[no_implicit_prelude] to the new attribute parsing infrastructure #143237 (Port #[no_implicit_prelude] to the new attribute parsing infrastructure)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

setup typos check in CI This allows to check typos in CI, currently for compiler only (to reduce commit size with fixes). With current setup, exclude list is quite short, so it worth trying? Also includes commits with actual typo fixes. MCP: rust-lang/compiler-team#817 typos check currently turned for: * ./compiler * ./library * ./src/bootstrap * ./src/librustdoc After merging, PRs which enables checks for other crates (tools) can be implemented too. Found typos will **not break** other jobs immediately: (tests, building compiler for perf run). Job will be marked as red on completion in ~ 20 secs, so you will not forget to fix it whenever you want, before merging pr. Check typos: `python x.py test tidy --extra-checks=spellcheck` Apply typo fixes: `python x.py test tidy --extra-checks=spellcheck:fix` (in case if there only 1 suggestion of each typo) Current fail in this pr is expected and shows how typo errors emitted. Commit with error will be removed after r+.

…ser, r=oli-obk Port `#[target_feature]` to new attribute parsing infrastructure Ports `target_feature` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? ``@jdonszelmann``

…-traits, r=tgross35 avoid suggesting traits from private dependencies fixes rust-lang#142676 fixes rust-lang#138191 r? ``@tgross35``

…nszelmann Fix rustdoc not correctly showing attributes on re-exports Fixes attributes not being shown correctly in rustdoc on re-exports Does this need to be backported to beta? r? ``@jdonszelmann``

…youxu document optional jobs

…unimplemented, r=jieyouxu minicore: use core's `diagnostic::on_unimplemented` messages Without these attributes, the error message is different. Keeping the diagnostics up-to-date seems related to rust-lang#137531. The modified test files are reported in rust-lang#143319 as failing for `--target=riscv64gc-unknown-linux-gnu`. Using `minicore` for them makes it easier to troubleshoot this sort of issue. r? ``@jieyouxu``

jdonszelmann · 2025-07-03T11:30:19Z

@bors r+ rollup=never p=5

bors · 2025-07-03T11:30:23Z

📌 Commit f85283b has been approved by jdonszelmann

It is now in the queue for this repository.

bors · 2025-07-03T13:55:10Z

⌛ Testing commit f85283b with merge a413f77...

bors · 2025-07-03T16:56:07Z

☀️ Test successful - checks-actions
Approved by: jdonszelmann
Pushing a413f77 to master...

rust-timer · 2025-07-03T16:57:52Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#134006	setup typos check in CI	`2f6cb4ed9dc4129ad9ccd9b6ea063cd9443e2e8a` (link)
#142876	Port `#[target_feature]` to new attribute parsing infrastru…	`c54242a15f6b6fb25c3b5827bfb906b9608b842a` (link)
#143038	avoid suggesting traits from private dependencies	`db103185feda4038c7a3649ac0a58f65c04606f0` (link)
#143083	Fix rustdoc not correctly showing attributes on re-exports	`b35e96694886a6a9bfe08df5f5b32b56aaa99180` (link)
#143283	document optional jobs	`d15c6f667770c9ca31a008f370de721270ac58de` (link)
#143329	minicore: use core's `diagnostic::on_unimplemented` messages	`fc57c8a1dab92bb2bdfbf340e03cedae55f0ce6b` (link)

previous master: 9e64506923

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-07-03T16:58:47Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9e64506 (parent) -> a413f77 (this PR)

Test differences

Show 60 test diffs

Stage 1

[rustdoc-json] tests/rustdoc-json/attrs/target_feature.rs: [missing] -> pass (J0)
[rustdoc] tests/rustdoc/attributes-re-export.rs: [missing] -> pass (J0)
[ui] tests/ui/typeck/dont-suggest-private-dependencies.rs: [missing] -> pass (J0)
errors::verify_codegen_ssa_feature_not_valid_135: [missing] -> pass (J4)
errors::verify_passes_non_exaustive_with_default_field_values_19: pass -> [missing] (J4)
errors::verify_passes_non_exhaustive_with_default_field_values_19: [missing] -> pass (J4)

Stage 2

[rustdoc] tests/rustdoc/attributes-re-export.rs: [missing] -> pass (J1)
[ui] tests/ui/typeck/dont-suggest-private-dependencies.rs: [missing] -> pass (J2)
[rustdoc-json] tests/rustdoc-json/attrs/target_feature.rs: [missing] -> pass (J3)
[rustdoc-json] tests/rustdoc-json/attrs/target_feature.rs: [missing] -> ignore (only executed when the architecture is x86_64) (J5)

Additionally, 50 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a413f77285c0ab551cf58db729e054f43150dd50 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 3695.9s -> 5069.4s (37.2%)
dist-aarch64-linux: 9234.2s -> 5822.7s (-36.9%)
aarch64-apple: 4515.3s -> 5667.5s (25.5%)
x86_64-rust-for-linux: 2555.7s -> 3028.1s (18.5%)
x86_64-apple-1: 7682.8s -> 9091.3s (18.3%)
dist-arm-linux-musl: 6488.0s -> 5397.1s (-16.8%)
pr-check-1: 1575.9s -> 1839.6s (16.7%)
dist-apple-various: 8129.0s -> 6792.2s (-16.4%)
dist-x86_64-apple: 10883.1s -> 9125.5s (-16.1%)
i686-gnu-2: 5475.2s -> 6267.8s (14.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-04T04:38:16Z

Finished benchmarking commit (a413f77): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	3.0%	[3.0%, 3.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.5%, -0.2%]	11
Improvements ✅ (secondary)	-0.4%	[-1.1%, -0.2%]	14
All ❌✅ (primary)	-0.0%	[-0.5%, 3.0%]	12

Max RSS (memory usage)

Results (primary -0.7%, secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-1.9%, -1.4%]	2
Improvements ✅ (secondary)	-1.8%	[-2.9%, -1.0%]	5
All ❌✅ (primary)	-0.7%	[-1.9%, 1.3%]	3

Cycles

Results (primary 3.0%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.0%	[2.9%, 3.1%]	2
Regressions ❌ (secondary)	2.2%	[2.0%, 2.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.8%	[-2.5%, -1.1%]	2
All ❌✅ (primary)	3.0%	[2.9%, 3.1%]	2

Binary size

Results (primary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[1.1%, 1.1%]	1

Bootstrap: 461.257s -> 461.296s (0.01%)
Artifact size: 372.16 MiB -> 372.12 MiB (-0.01%)

lqd · 2025-07-04T08:15:56Z

The usual clap-derive noise, and it returned to normal on the next merge.

@rustbot label: +perf-regression-triaged

JonathanBrouwer and others added 14 commits June 27, 2025 23:31

Fix rustdoc not correctly showing attributes with re-exports

58418d8

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

add failing test, bless incorrect output

3bf650f

make compiler_builtins a private dependency

1e6e4bb

document optional jobs

f5f2011

avoid suggesting traits from private dependencies

6b824e8

Port #[target_feature] to the new attribute parsing infrastructure

3d5d72b

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

setup CI and tidy to use typos for spellchecking and fix few typos

c76d032

minicore: use core's diagnostic::on_unimplemented messages

8512e39

Rollup merge of rust-lang#142876 - JonathanBrouwer:target_feature_par…

5026d0c

…ser, r=oli-obk Port `#[target_feature]` to new attribute parsing infrastructure Ports `target_feature` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? ``@jdonszelmann``

Rollup merge of rust-lang#143038 - Qelxiros:142676-private-dependency…

0aaac88

…-traits, r=tgross35 avoid suggesting traits from private dependencies fixes rust-lang#142676 fixes rust-lang#138191 r? ``@tgross35``

Rollup merge of rust-lang#143083 - JonathanBrouwer:rustdoc-fix, r=jdo…

622722a

…nszelmann Fix rustdoc not correctly showing attributes on re-exports Fixes attributes not being shown correctly in rustdoc on re-exports Does this need to be backported to beta? r? ``@jdonszelmann``

Rollup merge of rust-lang#143283 - marcoieni:document-optional, r=jie…

924a3e1

…youxu document optional jobs

rustbot added WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Jul 3, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025

bors mentioned this pull request Jul 3, 2025

Refactor StableMIR #140643

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 3, 2025

bors merged commit a413f77 into rust-lang:master Jul 3, 2025
12 checks passed

rustbot added this to the 1.90.0 milestone Jul 3, 2025

rustbot added the perf-regression Performance regression. label Jul 4, 2025

rustbot added the perf-regression-triaged The performance regression has been triaged. label Jul 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests #143363

Rollup of 6 pull requests #143363

jdonszelmann commented Jul 3, 2025 •

edited by rustbot

Loading

Uh oh!

jdonszelmann commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 3, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Jul 4, 2025

Uh oh!

lqd commented Jul 4, 2025

Uh oh!

Uh oh!

Rollup of 6 pull requests #143363

Rollup of 6 pull requests #143363

Conversation

jdonszelmann commented Jul 3, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdonszelmann commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 3, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jul 4, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

lqd commented Jul 4, 2025

Uh oh!

Uh oh!

jdonszelmann commented Jul 3, 2025 •

edited by rustbot

Loading