Skip to content

Remove PointerLike trait #143308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove PointerLike trait #143308

wants to merge 1 commit into from
+14 −288

Conversation

compiler-errors
Copy link
Member

r? oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 2, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
compiler-errors
compiler-errors commented Jul 2, 2025
View reviewed changes
compiler/rustc_middle/src/ty/mod.rs
// currently use pseudo-canonical queries in the trait solver which replaces params with
// placeholders. We should also simply not use pseudo-canonical queries in the trait
// solver, at which point we can readd this assert. As of writing this comment, this is
// only used by `fn layout_is_pointer_like` when calling `layout_of`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't true :)

@compiler-errors
Copy link
Member Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Jul 2, 2025

Is there context for this change?

@fmease
Copy link
Member

fmease commented Jul 2, 2025

removal of dyn*

@compiler-errors
Copy link
Member Author

Not needed anymore lol

@compiler-errors
Copy link
Member Author

Specifically, in #143036 (comment) I mentioned removing the PointerLike trait as one of the next steps, since PointerLike was specifically added for dyn* coercions and AFIDT support. Sorry for lack of context :D

@compiler-errors
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 3, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Jul 4, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 4, 2025

📌 Commit e2e3f58 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 4, 2025
@matthiaskrgr
Rollup merge of rust-lang#143308 - compiler-errors:no-pointer-like, r…
18b374d 
…=oli-obk

Remove `PointerLike` trait

r? oli-obk
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 4, 2025
Open
bors added a commit that referenced this pull request Jul 4, 2025
@bors
Auto merge of #143434 - matthiaskrgr:rollup-eyr4rcb, r=matthiaskrgr
0c4fa26 
Rollup of 7 pull requests

Successful merges:

 - #140643 (Refactor StableMIR)
 - #143286 (Make -Ztrack-diagnostics emit like a note)
 - #143308 (Remove `PointerLike` trait)
 - #143387 (Make __rust_alloc_error_handler_should_panic a function)
 - #143400 (Port `#[rustc_pass_by_value]` to the new attribute system)
 - #143417 (bump termize dep)
 - #143420 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @rust-log-analyzer @oli-obk @fmease @bors @rustbot