-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Upgrade the fortanix-sgx-abi
dependency
#143272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
@jethrogb mind taking a look at this? |
0.6.1 removes the `compiler-builtins` dependency, part of RUST-142265. The breaking change from 0.5 to 0.6 is for an update to the `insecure_time` API [1]. I validated that `./x c library --target x86_64-fortanix-unknown-sgx` completes successfully with this change. Link: fortanix/rust-sgx@a34e976 [1]
Unfortunately, we're missing documentation for the modified insecure_time call so I don't know if this is correct. |
Is this |
https://github.com/rust-lang/rust/blob/master/library/std/src/sys/pal/sgx/abi/usercalls/raw.rs But without documentation it's not really possible to determine whether the implementation is correct. |
0.6.1 removes the
compiler-builtins
dependency, part of RUST-142265. The breaking change from 0.5 to 0.6 is for an update to theinsecure_time
API [1].I validated that
./x c library --target x86_64-fortanix-unknown-sgx
completes successfully with this change.Link: fortanix/rust-sgx@a34e976 [1]