Rewrite empty attribute lint for new attribute parser #143252
Draft
+119
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
rustbot
added
A-attributes
|
☔ The latest upstream changes (presumably #143338) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
jdonszelmann
reviewed
Jul 3, 2025
| @@ -285,7 +283,7 @@ pub enum AttributeKind { | |||
| PubTransparent(Span), | |||
|
|
|||
| /// Represents [`#[repr]`](https://doc.rust-lang.org/stable/reference/type-layout.html#representations). | |||
| Repr(ThinVec<(ReprAttr, Span)>), | |||
| Repr(ThinVec<(ReprAttr, Span)>, Span), | |||
There was a problem hiding this comment.
could you call this field "first_span"?
There was a problem hiding this comment.
do you need this field at all if the warning always happens in thiscrate (attr_parsing)
| @@ -12,4 +12,5 @@ pub struct AttributeLint<Id> { | |||
| pub enum AttributeLintKind { | |||
| UnusedDuplicate { this: Span, other: Span, warning: bool }, | |||
| IllFormedAttributeInput { suggestions: Vec<String> }, | |||
| EmptyAttribute { span: Span }, | |||
| Target::Struct | Target::Union | Target::Enum => {} | ||
| Target::Fn | Target::Method(_) => { | ||
| self.dcx().emit_err(errors::ReprAlignShouldBeAlign { | ||
| span: first_attr_span, |
There was a problem hiding this comment.
right, with repr you need it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jdonszelmann
This is blocked on some of the changes from #142876