Rollup of 11 pull requests #143173
Merged
Rollup of 11 pull requests #143173
+580
−400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the rustc book to clearly document how conflicting lint configurations are resolved across different sources, including command-line flags, crate-level attributes, in-line attributes, and `--cap-lints`. It also explains the special behavior of `forbid` and `force_warn`.
To ensure used statics are functioning correctly for proc-macros too.
…ntra doc links for extern crate items.
Co-authored-by: Anne Stijns <anstijns@gmail.com> Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
…Drop #![feature(rustc_private)]
…c, r=ehuss Doc: clarify priority of lint level sources This updates the rustc book to clearly document how conflicting lint configurations are resolved across different sources, including command-line flags, crate-level attributes, in-line attributes, and `--cap-lints`. It also explains the special behavior of `forbid` and `force_warn`. Fixes rust-lang#124088
…intra-doc, r=lolbinarycat Add regression test for rust-lang#137857 to ensure that we generate intra doc links for extern crate items. Fixes rust-lang#137857. I checked that linking to extern crates was generating valid links (with the `/index.html` part) and since it's already working, just adding a regression test. r? `@notriddle`
…youxu Generate symbols.o for proc-macros too To ensure used statics are functioning correctly for proc-macros too.
…acrum Clarify doc comment on unix OpenOptions
explain `ImportData::imported_module` r? `@petrochenkov`
…tag, r=RalfJung Improve documentation of `TagEncoding` This PR is follow-up from the [discussion here](https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/.E2.9C.94.20VariantId.3DDiscriminant.20when.20tag.20is.20niche.20encoded.3F/with/524384295). It aims at making the `TagEncoding` documentation less ambiguous and more detailed with references to relevant implementation sides. It especially clears up the ambiguous use of discriminant/variant index, which sparked the discussion referenced above. PS: While working with layout data, I somehow ended up looking at the docs for `FakeBorrowKind` and noticed that the one example was not in a doc comment. I hope that this is minor enough of a fix for it to be okay in this otherwise unrelated PR.
fix typos on some doc comments
…r=jdonszelmann Port `#[link_name]` to the new attribute parsing infrastructure Ports `link_name` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? `@jdonszelmann`
… r=GuillaumeGomez `librustdoc` house-keeping 🧹 This PR mostly removes a bunch of crate-level attributes that were added at some point, but then later on became unnecessary: - some `#[feature]` gates - some `#[allow]`s - a `#[recursion_limit]` Then I went ahead and sprinkled some tidy sorting on the remaining attrs, and `Cargo.toml`. Trying to give my anal retentiveness some peace of mind 😅
…compiler-errors Remove unused feature gates After finding some unused feature gates in rust-lang#143155 , I wrote a small script to see if I can find any others. And I did. Not a lot, but still a small win 😁 Contains a few instances of `iter_from_coroutine` that can be removed due to rust-lang#142801 (I guess).
…, r=compiler-errors Fix the span of trait bound modifier `[const]` r? project-const-traits or anyone
rustbot
added
A-attributes
rustbot
added
O-unix
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: dddd7ab962 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing dddd7ab (parent) -> 5ca574e (this PR) Test differencesShow 71 test diffsStage 1
Stage 2
Additionally, 63 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 5ca574e85b67cec0a6fc3fddfe398cbe676c9c69 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Jun 29, 2025
|
Finished benchmarking commit (5ca574e): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 696.482s -> 695.013s (-0.21%) |
|
probably due to #142641 we are doing a little more work now ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ImportData::imported_module#143063 (explainImportData::imported_module)TagEncoding#143088 (Improve documentation ofTagEncoding)#[link_name]to the new attribute parsing infrastructure #143138 (Port#[link_name]to the new attribute parsing infrastructure)librustdochouse-keeping 🧹 #143155 (librustdochouse-keeping 🧹)[const]#143171 (Fix the span of trait bound modifier[const])r? @ghost
@rustbot modify labels: rollup
Create a similar rollup