Skip to content

Fix backtrace for cygwin #140398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

Fix backtrace for cygwin #140398

merged 1 commit into from
May 7, 2025
+3 −2

Conversation

Berrysoft
Copy link
Contributor

@Berrysoft Berrysoft commented Apr 28, 2025 •
edited
Loading

Closes #140304

Depends on:

This PR could not be merged until the above PR is merged. I'll update the submodule then.

EDIT: submodule updated.

@rustbot
Copy link
Collaborator

rustbot commented Apr 28, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 28, 2025
@tgross35
Copy link
Contributor

tgross35 commented May 1, 2025

This looks fine to me but for now,
@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2025
@Berrysoft Berrysoft marked this pull request as ready for review May 7, 2025 04:21
@rustbot
Copy link
Collaborator

rustbot commented May 7, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@Berrysoft
Copy link
Contributor Author

Q: I have found #140705 . Should the lock file also be updated?

@Berrysoft
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels May 7, 2025
@tgross35
Copy link
Contributor

tgross35 commented May 7, 2025

Something looks weird with the submodule history, like the first commit may have been updated from a fork. Could you squash this away?

Q: I have found #140705 . Should the lock file also be updated?

The lockfile only affects the compiler and the submodule is used by the standard library. It probably makes sense to update the compiler lockfile as well, but there hasn't been a release with the cygwin changes yet (the version published this morning is from January, it was just missing from crates.io).

@Berrysoft
Copy link
Contributor Author

OK... let the std work first, then

@Berrysoft Berrysoft force-pushed the cygwin-backtrace branch from 473da5b to fe64184 Compare May 7, 2025 05:08
@tgross35
Copy link
Contributor

tgross35 commented May 7, 2025

Ideally we would probably bump both at the same time, but it looks like the current submodule head is between releases anyway so no harm adding the cygwin changes.

@bors r+

@bors
Copy link
Collaborator

bors commented May 7, 2025

📌 Commit fe64184 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request May 7, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2025
@bors
Auto merge of rust-lang#140735 - GuillaumeGomez:rollup-dlhbxsg, r=Gui…
db0e836 
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#139518 (Stabilize precise capture syntax in style guide)
 - rust-lang#140398 (Fix backtrace for cygwin)
 - rust-lang#140719 (fix typo in autorefs lint doc example)
 - rust-lang#140724 (Update `compiler-builtins` to 0.1.158)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6e2c39b into rust-lang:master May 7, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone May 7, 2025
@Berrysoft Berrysoft deleted the cygwin-backtrace branch May 7, 2025 12:39
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2025
@rust-timer
Unrolled build for rust-lang#140398
0780bfe 
Rollup merge of rust-lang#140398 - Berrysoft:cygwin-backtrace, r=tgross35

Fix backtrace for cygwin

Closes rust-lang#140304

Depends on:
- [x] rust-lang/backtrace-rs#704

This PR could not be merged until the above PR is merged. I'll update the submodule then.

EDIT: submodule updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.

Cygwin doesn't report correct backtrace on panic
4 participants
@Berrysoft @rustbot @tgross35 @bors