Skip to content

Copy generics from functions to Return Position Impl Traits in HIR lowering #101345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 53 commits into from
Closed

Copy generics from functions to Return Position Impl Traits in HIR lowering #101345

Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
7bbe7b6
Set up new approach for impl trait in return position
spastorino May 11, 2022
b3cc702
Make RPIT not inherit generics from its function
spastorino May 11, 2022
bae1deb
Call mk_param_from_def for all params
spastorino May 20, 2022
a5f8780
Copy generic parameters from function to impl trait opaque type
spastorino May 17, 2022
c1f8fbd
Test nested impl trait in return position
spastorino May 19, 2022
2cccbc4
Add generic type and const args to OpaqueDef
spastorino May 19, 2022
bb28711
Handle all kind of generic args when converting to ty
spastorino May 20, 2022
f60f609
param_env def_id is the one of the opaque type for RPIT
spastorino May 20, 2022
a71699d
Properly gather explicit predicates of opaque type
spastorino May 20, 2022
a311717
is_impl_trait_defn doesn't have any effect now with RPIT
spastorino May 20, 2022
4642ec9
register_member_constraints is 0 for RPIT
spastorino May 20, 2022
35a98a7
gather_explicit_predicates_of return empty for OpaqueTyOrigin::AsyncFn
spastorino Jun 30, 2022
fee7dc6
Properly type check type parameter predicates for RPIT
spastorino May 20, 2022
df9356d
Properly handle Const generics
spastorino May 21, 2022
79eeffa
Pass Generics to lower impl trait instead of generic params
spastorino May 23, 2022
d102712
Copy generic param bounds and where clauses from function to RPIT
spastorino May 23, 2022
8d26963
Remap on lower_res
spastorino Aug 5, 2022
a08ff68
Lower lifetime bounds/predicates as static if not part of RPIT bounds
spastorino Aug 5, 2022
cce5412
Add APIT test for RPIT v2
spastorino May 24, 2022
3b4ab9d
Add bounds regression test for RPIT v2
spastorino May 24, 2022
be33fa2
Add generic associated type test for RPIT v2
spastorino May 24, 2022
c67ab47
Add where bounds test for RPIT v2
spastorino May 24, 2022
064675d
Lower APIT generics to RPIT
spastorino Jun 8, 2022
50bc776
Copy generic params from outer impl/trait blocks to RPIT
spastorino Aug 10, 2022
8f20d42
Add debug call on rustc_middle generics
spastorino Aug 10, 2022
98d43e5
Supress warn on artificial static lifetimes for RPIT
spastorino Aug 10, 2022
cfa73f8
instrument type param predicates and bounds in generic fns
spastorino Jun 30, 2022
9118087
Add APIT with lifetimes test
spastorino Jun 28, 2022
3049a8d
Add a simple APIT test
spastorino Sep 2, 2022
8b5c082
Add lifetimes bounds test
spastorino Sep 2, 2022
1563a66
Do not assert impl_trait_* is_empty
spastorino Jul 5, 2022
54d5fa4
Add debug information
spastorino Jul 5, 2022
faafdf1
Add APIT anonymous lifetime test
spastorino Aug 10, 2022
fff4d31
Add trait bound anonymous lifetime test
spastorino Aug 16, 2022
f08f19e
Create definitions and remap lifetimes in lower_lifetime_binder
spastorino Aug 18, 2022
697393f
save/restore the node-id table for poly-trait-ref
spastorino Sep 2, 2022
9f8a343
impl/block types are first and then fn types
spastorino Aug 23, 2022
f514607
Remove return_position_impl_trait_v2 feature flag and make it default
spastorino Aug 23, 2022
25bbe2a
Remove reborrow in favor of passing &mut
spastorino Sep 2, 2022
bab1d54
Pass generics info from context down to the inner rpits on async fns
spastorino Aug 25, 2022
a19d07e
Push apit nodes before lowering generics and bounds
spastorino Aug 24, 2022
679293a
Do not create new defs and remaps when lowering Universal inside RPITs
spastorino Aug 31, 2022
be98207
Only create def and remap on lower_lifetime_binder for RPITs and not …
spastorino Sep 1, 2022
f16d7fe
Ignore where-clauses wf checks for RPITs they are kinda bogus
spastorino Sep 1, 2022
7200539
Bless impl-trait-captures test as the output is better now
spastorino Aug 25, 2022
a4356ee
Bless async test
spastorino Sep 2, 2022
0791f8d
Bless bound-normalization-fail test
spastorino Aug 25, 2022
8d53dc7
Avoid unneeded repeated code
spastorino Sep 2, 2022
49d057f
itertools is not needed anymore in rustc_ast_lowering
spastorino Sep 2, 2022
0fadeed
Add debug_asserts back
spastorino Sep 5, 2022
835d7de
call lower_span before adding it to GenericArg::Type
spastorino Sep 5, 2022
971641f
Move itctx creation to outside loop
spastorino Sep 5, 2022
d45f1d3
Extend Rustdocs of lower_lifetime_binder
spastorino Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions compiler/rustc_ast_lowering/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,9 +626,6 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {

let item = f(self);
debug_assert_eq!(def_id, item.def_id());
// `f` should have consumed all the elements in these vectors when constructing `item`.
debug_assert!(self.impl_trait_defs.is_empty());
debug_assert!(self.impl_trait_bounds.is_empty());
let info = self.make_owner_info(item);

self.attrs = current_attrs;
Expand Down