Skip to content

Add enhanced plain logs link to triagebot #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Jun 30, 2025

This is a follow-up to rust-lang/triagebot#2076 to automatically link to triagebot new /gha-logs/:owner/:repo/:log-id endpoint which displays ANSI-processed GHA logs.

I choose to add the link as an extra link: (plain enhanced), so that users can still go to the web version or plain raw logs if they which.

r? @Kobzol

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about calling it "colored"? But it doesn't really matter I guess, once people find out what it does, they'll remember it.

@Urgau
Copy link
Member Author

Urgau commented Jun 30, 2025

WDYT about calling it "colored"?

It does more than color, it also handles links, bold, italic and underline.

@Urgau Urgau force-pushed the plain_enhanced_triagebot branch from 13ba68a to 02cb713 Compare June 30, 2025 19:44
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Thank you! Let's see how it works in practice.

@Kobzol Kobzol enabled auto-merge June 30, 2025 19:46
@Kobzol Kobzol merged commit 26a0460 into rust-lang:master Jun 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants