Skip to content

needless_return: do not lint on proc macros #15329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blyxyas
Copy link
Member

@blyxyas blyxyas commented Jul 23, 2025

Due to the complexity of the issue and the simplicity of the fix, I'm not being able to reproduce it in the tests (I'm not even being able to reproduce to issue to begin with), but testing it on upstream rust, the panic no longer occurs.

fixes #15338

changelog:[needless_return]: Do not run in proc macros.

@rustbot
Copy link
Collaborator

rustbot commented Jul 23, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected panic in rustc_query_system while running 'x clippy'
3 participants