Skip to content

Do not build tokio-rustls in the CI for the time being #14517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Do not build tokio-rustls in the CI for the time being #14517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/lintcheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ jobs:
path: target/debug/lintcheck
key: lintcheck-bin-${{ hashfiles('lintcheck/**') }}

# Install cmake to build aws-lc-sys to build tokio-rustls
- name: Install cmake
run: sudo apt-get install -y cmake

- name: Build lintcheck
if: steps.cache-lintcheck-bin.outputs.cache-hit != 'true'
run: cargo build --manifest-path=lintcheck/Cargo.toml
Expand Down Expand Up @@ -96,10 +92,6 @@ jobs:
path: target/debug/lintcheck
key: lintcheck-bin-${{ hashfiles('lintcheck/**') }}

# Install cmake to build aws-lc-sys to build tokio-rustls
- name: Install cmake
run: sudo apt-get install -y cmake

- name: Build lintcheck
if: steps.cache-lintcheck-bin.outputs.cache-hit != 'true'
run: cargo build --manifest-path=lintcheck/Cargo.toml
Expand Down
3 changes: 2 additions & 1 deletion lintcheck/ci_crates.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ winnow = { name = 'winnow', version = '0.6.13' }
cpufeatures = { name = 'cpufeatures', version = '0.2.12' }
nix = { name = 'nix', version = '0.29.0' }
fnv = { name = 'fnv', version = '1.0.7' }
tokio-rustls = { name = 'tokio-rustls', version = '0.26.0' }
# As of 2025-04-01, one dependency doesn't build because of cmake version discrepancy
# tokio-rustls = { name = 'tokio-rustls', version = '0.26.0' }
iana-time-zone = { name = 'iana-time-zone', version = '0.1.60' }
rustls-webpki = { name = 'rustls-webpki', version = '0.102.5' }
crc32fast = { name = 'crc32fast', version = '1.4.2' }
Expand Down