Migrate replace derive with manual impl and add_missing_impl_members to use SyntaxEditor
#20293
+319
−238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Oh, the test added from #19938 are failing |
| @@ -185,71 +185,65 @@ pub fn add_trait_assoc_items_to_impl( | |||
| trait_: hir::Trait, | |||
| impl_: &ast::Impl, | |||
| target_scope: &hir::SemanticsScope<'_>, | |||
| ) -> ast::AssocItem { | |||
| ) -> Vec<ast::AssocItem> { | |||
There was a problem hiding this comment.
I think it would be good to have #[must_use] attributes here, as this is not mutating existing syntax tree anymore but returns a new one. (And this would help preventing tests in #19938 failing, though I've merged it after this PR was created 😅 )
There was a problem hiding this comment.
Thanks for finding the fix spot!
This comment has been minimized.
This comment has been minimized.
rustbot
added
has-merge-commits
S-waiting-on-author
|
Sorry, I made a mistake merge. |
…pl_members Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
Hmikihiro
force-pushed
the
migrate_replace_derive_with_manual_impl
branch
from
50f8ef6 to
82dfdac
Compare
rustbot
removed
S-waiting-on-author
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #15710 and #18285
fn add_trait_assoc_items_to_impluse ted yet.