Skip to content

Add fn load_workspace_into_db variant for ra_ap_load_cargo's fn load_workspace #20144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions crates/load-cargo/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,23 @@ pub fn load_workspace(
extra_env: &FxHashMap<String, Option<String>>,
load_config: &LoadCargoConfig,
) -> anyhow::Result<(RootDatabase, vfs::Vfs, Option<ProcMacroClient>)> {
let lru_cap = std::env::var("RA_LRU_CAP").ok().and_then(|it| it.parse::<u16>().ok());
let mut db = RootDatabase::new(lru_cap);

let (vfs, proc_macro_server) = load_workspace_into_db(ws, extra_env, load_config, &mut db)?;

Ok((db, vfs, proc_macro_server))
}

// This variant of `load_workspace` allows deferring the loading of rust-analyzer
// into an existing database, which is useful in certain third-party scenarios,
// now that `salsa` supports extending foreign databases (e.g. `RootDatabase`).
pub fn load_workspace_into_db(
ws: ProjectWorkspace,
extra_env: &FxHashMap<String, Option<String>>,
load_config: &LoadCargoConfig,
db: &mut RootDatabase,
) -> anyhow::Result<(vfs::Vfs, Option<ProcMacroClient>)> {
let (sender, receiver) = unbounded();
let mut vfs = vfs::Vfs::default();
let mut loader = {
Expand Down Expand Up @@ -139,18 +156,19 @@ pub fn load_workspace(
version: 0,
});

let db = load_crate_graph(
load_crate_graph_into_db(
crate_graph,
proc_macros,
project_folders.source_root_config,
&mut vfs,
&receiver,
db,
);

if load_config.prefill_caches {
prime_caches::parallel_prime_caches(&db, 1, &|_| ());
prime_caches::parallel_prime_caches(db, 1, &|_| ());
}
Ok((db, vfs, proc_macro_server.ok()))
Ok((vfs, proc_macro_server.ok()))
}

#[derive(Default)]
Expand Down Expand Up @@ -417,15 +435,14 @@ pub fn load_proc_macro(
}
}

fn load_crate_graph(
fn load_crate_graph_into_db(
crate_graph: CrateGraphBuilder,
proc_macros: ProcMacrosBuilder,
source_root_config: SourceRootConfig,
vfs: &mut vfs::Vfs,
receiver: &Receiver<vfs::loader::Message>,
) -> RootDatabase {
let lru_cap = std::env::var("RA_LRU_CAP").ok().and_then(|it| it.parse::<u16>().ok());
let mut db = RootDatabase::new(lru_cap);
db: &mut RootDatabase,
) {
let mut analysis_change = ChangeWithProcMacros::default();

db.enable_proc_attr_macros();
Expand Down Expand Up @@ -462,7 +479,6 @@ fn load_crate_graph(
analysis_change.set_proc_macros(proc_macros);

db.apply_change(analysis_change);
db
}

fn expander_to_proc_macro(
Expand Down