warn unused config: rev0.5

lijinpei · lijinpei · commit 888ed246cca4 · 2019-02-10T01:19:12.000+08:00
diff --git a/src/server/mod.rs b/src/server/mod.rs
@@ -85,15 +85,15 @@ impl BlockingRequestAction for ShutdownRequest {
     }
 }
 
-pub(crate) fn maybe_notify_unknown_configs<O: Output>(out: &O, unknowns: &Vec<(String)>) {
+pub(crate) fn maybe_notify_unknown_configs<O: Output>(out: &O, unknowns: &[String]) {
     use std::fmt::Write;
     if unknowns.is_empty() {
         return;
     }
     let mut msg = "Unknown RLS configuration:".to_string();
     let mut first = true;
     for key in unknowns {
-        write!(msg, "{}`{}` ", if first {' '} else {','}, key.clone()).unwrap();
+        write!(msg, "{}`{}` ", if first {' '} else {','}, key).unwrap();
         first = false;
     }
     out.notify(Notification::<ShowMessage>::new(ShowMessageParams {

Original file line number	Diff line number	Diff line change
`@@ -85,15 +85,15 @@ impl BlockingRequestAction for ShutdownRequest {`
`85`	`85`	`}`
`86`	`86`	`}`
`87`	`87`
`88`		`-pub(crate) fn maybe_notify_unknown_configs<O: Output>(out: &O, unknowns: &Vec<(String)>) {`
	`88`	`+pub(crate) fn maybe_notify_unknown_configs<O: Output>(out: &O, unknowns: &[String]) {`
`89`	`89`	`use std::fmt::Write;`
`90`	`90`	`if unknowns.is_empty() {`
`91`	`91`	`return;`
`92`	`92`	`}`
`93`	`93`	`let mut msg = "Unknown RLS configuration:".to_string();`
`94`	`94`	`let mut first = true;`
`95`	`95`	`for key in unknowns {`
`96`		- write!(msg, "{}`{}` ", if first {' '} else {','}, key.clone()).unwrap();
	`96`	+ write!(msg, "{}`{}` ", if first {' '} else {','}, key).unwrap();
`97`	`97`	`first = false;`
`98`	`98`	`}`
`99`	`99`	`out.notify(Notification::<ShowMessage>::new(ShowMessageParams {`