warn unused config: rev0.4

Author: lijinpei

src/lsp_data.rs

@@ -268,11 +268,9 @@ impl ChangeConfigSettings {
                     continue;
                 }
                 if let serde_json::Value::Object(_) = v {
-                    let mut unknowns1 = Vec::<String>::new();
-                    if let Ok(rust) = config::Config::try_deserialize(v, dups, &mut unknowns1) {
+                    if let Ok(rust) = config::Config::try_deserialize(v, dups, unknowns) {
                         ret = Ok(ChangeConfigSettings{rust: rust});
                     }
-                    unknowns.extend(unknowns1.iter().map(|s| format!("rust.{}", s)));
                 } else {
                     return Err(());
                 }

src/server/mod.rs

@@ -90,9 +90,11 @@ pub(crate) fn maybe_notify_unknown_configs<O: Output>(out: &O, unknowns: &Vec<(S
     if unknowns.is_empty() {
         return;
     }
-    let mut msg = String::new();
+    let mut msg = "Unknown RLS configuration:".to_string();
+    let mut first = true;
     for key in unknowns {
-        write!(msg, "unknown RLS configuration: {}; ", key.clone()).ok();
+        write!(msg, "{}`{}` ", if first {' '} else {','}, key.clone()).unwrap();
+        first = false;
     }
     out.notify(Notification::<ShowMessage>::new(ShowMessageParams {
         typ: MessageType::Warning,
@@ -107,15 +109,17 @@ pub(crate) fn maybe_notify_duplicated_configs<O: Output>(out: &O, dups: &std::co
     }
     let mut msg = String::new();
     for kv in dups {
-        write!(msg, "{}: ", kv.0).ok();
+        write!(msg, "{}:", kv.0).unwrap();
+        let mut first = true;
         for v in kv.1 {
-            write!(msg, "{}, ", v).ok();
+            write!(msg, "{}{}, ", if first {' '} else {','}, v).unwrap();
+            first = false;
         }
         msg += "; ";
     }
     out.notify(Notification::<ShowMessage>::new(ShowMessageParams {
         typ: MessageType::Warning,
-        message: format!("duplicated RLS configuration: {}", msg.clone()),
+        message: format!("Duplicated RLS configuration: {}", msg.clone()),
     }));
 }
 

tests/client.rs

@@ -1281,21 +1281,19 @@ fn client_deglob() {
 }
 
 fn is_notification_for_unknown_config(msg:&serde_json::Value) -> bool {
-    eprintln!("unk msg: {}", msg);
     msg["method"] == ShowMessage::METHOD
             && msg["params"]["message"]
                 .as_str()
                 .unwrap()
-                .contains("unknown")
+                .contains("Unknown")
 }
 
 fn is_notification_for_duplicated_config(msg:&serde_json::Value) -> bool {
-    eprintln!("dup msg: {}", msg);
     msg["method"] == ShowMessage::METHOD
             && msg["params"]["message"]
                 .as_str()
                 .unwrap()
-                .contains("duplicate")
+                .contains("Duplicate")
 }
 
 #[test]