Skip to content

#[doc(consts)] #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 134 additions & 0 deletions text/0000-doc-consts.md
Copy link
Member

@fmease fmease Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one good way to make proper progress on this RFC and bring it out of its draft status, would be to schedule some sort of "deep dive session" where interested parties can come together and investigate whether we as rustdoc can guarantee to take this attribute into account in all cases from an implementation perspective or whether we need to downgrade it to a "hint".

Re. "cases", I'm referring to local vs. inlined cross-crate or more precisely lowering from HIR vs middle::ty IR / MIR (ValTree, mir::Const, ty::Const).

Copy link
Member

@fmease fmease Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this, I'm also interested in talking about what "fold" and "expr" entail precisely, namely what guarantees we're willing to make if any.

  1. For "expr", for example whether we want to promise preserving "lexical information" like number bases (e.g., 0xFF), underscores (e.g., 1_000) (some users really love to keep this behavior (in the local case)).
    • I don't remember if it's preserved in the HIR but even if it's not, then in some cases it's obtainable via SourceMap. IIRC rustdoc currently does look at the SourceMap to achieve this
    • Obviously for the cross-crate case, middle::ty IR / MIR doesn't contain these pieces of information (and it will never do), so we'd need to use "JS side files" or something like that etc etc
  2. For "fold",
    • for example what to do if the const expr "is too generic" or if it diverges1 (hard error vs. keeping the unnormalized form around (and emit a lint warning?))
    • or whether we want to refrain from normalizing away "paths" (const aliases/projections is the proper term) referring to public const items similar to type aliases (which is based on rustdoc's IR "clean AST")). Whether that's even possible to do (custom normalization logic) if we have a MIR const or a ValTree assuming we want to throw out our "clean AST"-based normalization logic for good. Etc etc.

Footnotes

  1. This comes up with assoc consts that normally don't get eval'ed if not referenced.

Original file line number Diff line number Diff line change
@@ -0,0 +1,134 @@
- Feature Name: `doc_consts`
- Start Date: 2025-01-20
- RFC PR: [rust-lang/rfcs#0000](https://github.com/rust-lang/rfcs/pull/0000)
- Rust Issue: [rust-lang/rust#0000](https://github.com/rust-lang/rust/issues/0000)
- Pre-RFC: [Pre-RFC: `#[doc(consts)]` attribute](https://internals.rust-lang.org/t/pre-rfc-doc-consts-attribute/21987)

# Summary
[summary]: #summary

Introduce a `#[doc(consts = ...)]` attribute controlling how constant expressions are rendered by rustdoc.

# Motivation
[motivation]: #motivation

Different crates and items have conflicting requirements for their constants.
For some, [the exact value of a constant is platform dependant](https://internals.rust-lang.org/t/pre-rfc-doc-consts-attribute/21987/9).
For others, [constant folding obsurces the meaning of values](https://github.com/rust-lang/rust/issues/128347).
Hovever, [showing a constant as written may leak implementation details],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a link missing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's one of the linked issues in rust-lang/rust#99688 (i'll go dig through it in a bit)

and in some cases, there is no possible value


# Guide-level explanation
[guide-level-explanation]: #guide-level-explanation

The `#[doc(consts)]` attribute can be placed on any item to control how contained constant expressions are displayed in rustdoc-generated documentation.

* `#[doc(consts = "fold")]` will show them in their fully-evaluated state.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about "eval" for fully evaluated item and "as-is" for item as written?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"constant folding" is a well established term used for this exact process, and "eval" is much more general (future display modes would likely also involve evaluating the expression).

on the other hand, i don't feel strongly about "expr", but my second choice would probably be "verbatim".

Copy link
Contributor

@tgross35 tgross35 Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Rust ever refer to CTFE as constant folding? The docs use evaluation https://doc.rust-lang.org/reference/const_eval.html, and to me "const folding" is an identify+transform optimization pass (as opposed to compile-time evaluation that must unconditionally be run).

* `#[doc(consts = "expr")]` will show them as-written
* `#[doc(consts = "hide")]` will cause constant expressions to be replaced with `_` or not shown at all.


# Reference-level explanation
[reference-level-explanation]: #reference-level-explanation


## The Attribute
The `#[doc(consts)]` attribute determines how constant expressions (constexprs) are rendered by rustdoc.
When applied to any item (including the top-level module within a crate, or impl blocks), it affects all constexprs within that item, and within all childern of that item.
Whenever multiple such attributes would take effect, the innermost attribute takes priority.

constexprs affected include:
* the RHS of `const` items
* the RHS of `static` items
* const generics in type aliases

## The Values

### "fold"
The current default. Rustdoc will evaluate the constexpr and print it in its fully evaluated form, as if the constexpr was written as a literal.

Numbers will be printed in base 10.

### "expr"
Rustdoc will print the constexpr as-written.

If the constexpr contains private identifiers, they will be exposed, so library authors should take care when using this mode.

### "hide"
This will cause constants and statics to display without any value, as if the value was unrenderable (see [ONCE_INIT](https://doc.rust-lang.org/nightly/std/sync/constant.ONCE_INIT.html)), and will cause other constant expressions–such as generic const parameters–to be rendered as `_`.
<!--This is the technical portion of the RFC. Explain the design in sufficient detail that:

- Its interaction with other features is clear.
- It is reasonably clear how the feature would be implemented.
- Corner cases are dissected by example.

The section should return to the examples given in the previous section, and explain more fully how the detailed proposal makes those examples work. -->

# Drawbacks
[drawbacks]: #drawbacks

Rustdoc does not currently have the ability to show all constants as-written, namely in the case of inlined re-exports from other crates.

# Rationale and alternatives
[rationale-and-alternatives]: #rationale-and-alternatives

- Why is this design the best in the space of possible designs?
- What other designs have been considered and what is the rationale for not choosing them?
- What is the impact of not doing this?
- If this is a language proposal, could this be done in a library or macro instead? Does the proposed change make Rust code easier or harder to read, understand, and maintain?

# Prior art
[prior-art]: #prior-art


- [RFC 3631](https://github.com/rust-lang/rfcs/pull/3631) for an attribute that affects the rendering of child items in a nesting way.

<!--- For language, library, cargo, tools, and compiler proposals: Does this feature exist in other programming languages and what experience have their community had?
- For community proposals: Is this done by some other community and what were their experiences with it?
- For other teams: What lessons can we learn from what other communities have done here?
- Papers: Are there any published papers or great posts that discuss this? If you have some relevant papers to refer to, this can serve as a more detailed theoretical background.

This section is intended to encourage you as an author to think about the lessons from other languages, provide readers of your RFC with a fuller picture.
If there is no prior art, that is fine - your ideas are interesting to us whether they are brand new or if it is an adaptation from other languages.

Note that while precedent set by other languages is some motivation, it does not on its own motivate an RFC.
Please also take into consideration that rust sometimes intentionally diverges from common language features.-->

# Unresolved questions
[unresolved-questions]: #unresolved-questions

- What should be happen rustdoc cannot format a constant as requested?
- How should structs be handled in `"expr"` mode?

<!--
- What parts of the design do you expect to resolve through the RFC process before this gets merged?
- What parts of the design do you expect to resolve through the implementation of this feature before stabilization?
- What related issues do you consider out of scope for this RFC that could be addressed in the future independently of the solution that comes out of this RFC?
-->

# Future possibilities
[future-possibilities]: #future-possibilities

- Controlling the base of folded integer literals.
- Allowing the attribute on individual constant expressions, such as if a type alias has multible const generics that should be rendered differntly.
- Seperatly specifying the rendering for different categories of constant expressions, such as declaring that only `static` items should have their value hidden.
- Control formatting of expression (collapsing/adding whitespace, etc.)

<!--Think about what the natural extension and evolution of your proposal would
be and how it would affect the language and project as a whole in a holistic
way. Try to use this section as a tool to more fully consider all possible
interactions with the project and language in your proposal.
Also consider how this all fits into the roadmap for the project
and of the relevant sub-team.

This is also a good place to "dump ideas", if they are out of scope for the
RFC you are writing but otherwise related.

If you have tried and cannot think of any future possibilities,
you may simply state that you cannot think of anything.

Note that having something written down in the future-possibilities section
is not a reason to accept the current or a future RFC; such notes should be
in the section on motivation or rationale in this or subsequent RFCs.
The section merely provides additional information. -->