Document (tuple) struct pattern namespace behavior #1925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
traviscross
force-pushed
the
TC/tuple-struct-pattern-namespaces
branch
from
a41a307 to
efba56c
Compare
rustbot
removed
the
S-waiting-on-review
traviscross
force-pushed
the
TC/tuple-struct-pattern-namespaces
branch
5 times, most recently
from
a8117db to
5ac3277
Compare
rustbot
added
the
S-waiting-on-review
We had not documented what namespaces were used when matching struct and tuple struct patterns. As it turns out, this is a bit nuanced. Let's document the current behavior, describe the nature of this nuance with an example, and note the possible uncertainly about the desirability of this behavior long-term.
traviscross
force-pushed
the
TC/tuple-struct-pattern-namespaces
branch
from
5ac3277 to
a170307
Compare
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had not documented what namespaces were used when matching struct and tuple struct patterns. As it turns out, this is a bit nuanced. Let's document the current behavior, describe the nature of this nuance with an example, and note the possible uncertainly about the desirability of this behavior long-term.
cc @ehuss