Update should_panic to use the attribute template
#1882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
traviscross
approved these changes
Jul 3, 2025
The test functions within our code blocks will not actually be run in any case, so let's mark these tests as `no_run`. In the examples, let's demonstrate the behavior that the expected string must be a substring of the panic message. Let's also tighten up some wording.
We currently accept invalid syntax between the parentheses with `should_panic(..)`. Let's make a note of that.
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rules:
attributes.testing.should_panic.allowed-positionsattributes.testing.should_panic.duplicatesattributes.testing.should_panic.expected(split from syntax)attributes.testing.should_panic.return(split from intro)Removed rules:
attributes.testing.should_panic.behavior--- This is duplicated in the intro. I'm uncertain how I want to handle that. I kind of want to always have a behavior rule, but it feels weird to essentially repeat the exact same words.