Skip to content

Commit bbff20e

Browse files
committed
Always promote a new version
New binaries of `rustup` are now uploaded to the `rustup-builds` bucket on S3 and no longer to `dev-static`, which means that they cannot be tested without performing a release to the `beta` channel first. This must include promoting the release and copying the binaries into the `dev-static` bucket.
1 parent fbb3508 commit bbff20e

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/rustup.rs

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,8 @@ impl Context {
4545
/// derived from the Cargo.toml file in the `stable` branch. `UPLOAD_BUCKET` can either be the
4646
/// `dev-static` or the `static` bucket.
4747
///
48-
/// If the release is for the `stable` channel, the artifacts are also copied to the `dist/`
49-
/// path in the `UPLOAD_BUCKET` bucket. The `dist/` path is used by the `rustup` installer to
50-
/// download the latest release.
48+
/// The artifacts are also copied to the `dist/` path in the `UPLOAD_BUCKET` bucket, which is
49+
/// used by the `rustup` installer to download the latest release.
5150
///
5251
/// Then, the `release-stable.toml` manifest is updated with the new version and copied to
5352
/// `s3://${UPLOAD_BUCKET}/rustup/release-stable.toml`.
@@ -70,10 +69,8 @@ impl Context {
7069
// Archive the artifacts
7170
self.archive_rustup_artifacts(&dist_dir, &version)?;
7271

73-
if self.config.channel == Channel::Stable {
74-
// Promote the artifacts to the release bucket
75-
self.promote_rustup_artifacts(&dist_dir)?;
76-
}
72+
// Promote the artifacts to the release bucket
73+
self.promote_rustup_artifacts(&dist_dir)?;
7774

7875
// Update the release number
7976
self.update_rustup_release(&version)?;

0 commit comments

Comments
 (0)