trace: incorporate events #4456
Open
+182
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I forgot I rebased this on top of #4435. Just the last commit is relevant for now |
nia-e
force-pushed
the
trace-incorporate-events
branch
2 times, most recently
from
acbf7f3 to
a8694a4
Compare
RalfJung
added
the
S-blocked
nia-e
force-pushed
the
trace-incorporate-events
branch
5 times, most recently
from
4326ab5 to
180efe5
Compare
nia-e
commented
Jul 8, 2025
|
What this PR definitely needs is some tests. :) Remember that tracing mode is off-by-default; none of the tests hit the tracing infra. So this needs some new native-mode tests that specifically check that we detect the ranges properly. For instance, sharing a 2-field uninit struct with C, having C initialize the first field, and then reading the 2nd field -- that should be UB. |
|
I actually wrote some! Just didn't know if they belong here. I'll add them, though |
nia-e
commented
Jul 9, 2025
nia-e
force-pushed
the
trace-incorporate-events
branch
4 times, most recently
from
14657e3 to
9b408f4
Compare
wip: tests
nia-e
force-pushed
the
trace-incorporate-events
branch
from
6d91006 to
3d16495
Compare
rust-bors bot
added a commit
to rust-lang/rust
that referenced
this pull request
Jul 9, 2025
interpret/allocation: expose init + write_wildcards on a range Part of rust-lang/miri#4456, so that we can mark down when a foreign access to our memory happened. Should this also move `prepare_for_native_access()` itself into Miri, given that everything there can be implemented on Miri's side? r? `@RalfJung`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If tracing is enabled, use the info from the trace to actually update Miri's state. Pending a small change to rustc to expose some necessary interfaces to handle writes, this should be good!