Skip to content

Fix relative links to README.md files #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions src/preprocess/index.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ impl Preprocessor for IndexPreprocessor {
path.set_file_name("index.md");
}
}

ch.content = convert_links_to_readme_files(&ch.content);
}
});

Expand Down Expand Up @@ -78,6 +80,22 @@ fn is_readme_file<P: AsRef<Path>>(path: P) -> bool {
)
}

fn convert_links_to_readme_files(s: &str) -> String {
static README_LINK: Lazy<Regex> = Lazy::new(|| {
Regex::new(r"(?i)(?P<before>\[.+\]\([^:]*)readme(?P<after>\.md(?:.{0}|#.*)\))").unwrap()
});

README_LINK
.replace_all(s, |caps: &regex::Captures<'_>| {
format!(
"{before}index{after}",
before = &caps["before"],
after = &caps["after"],
)
})
.to_string()
}

#[cfg(test)]
mod tests {
use super::*;
Expand All @@ -102,4 +120,58 @@ mod tests {
let path = "path/to/README-README.md";
assert!(!is_readme_file(path));
}

#[test]
fn test_convert_links_to_readme_files() {
let content = "Prologue\n\nSome text [link](./README.md)\n\nEpilogue";
assert_eq!(
convert_links_to_readme_files(&content),
"Prologue\n\nSome text [link](./index.md)\n\nEpilogue"
);

let content = "[link](./README.md)\n\nEpilogue";
assert_eq!(
convert_links_to_readme_files(&content),
"[link](./index.md)\n\nEpilogue"
);

let content = "Prologue\n\nSome text [link](./README.md)";
assert_eq!(
convert_links_to_readme_files(&content),
"Prologue\n\nSome text [link](./index.md)"
);

let content = "[link](./readme.md)";
assert_eq!(
convert_links_to_readme_files(&content),
"[link](./index.md)"
);

let content = "[link](./README.mdx)";
assert_eq!(convert_links_to_readme_files(&content), content);

let content = "[link](../chapter_1/README.md)";
assert_eq!(
convert_links_to_readme_files(&content),
"[link](../chapter_1/index.md)"
);

let content = "[link](./readme.md/chapter_1.1.md)";
assert_eq!(convert_links_to_readme_files(&content), content);

let content = "[link](./README.md#heading-1)";
assert_eq!(
convert_links_to_readme_files(&content),
"[link](./index.md#heading-1)"
);

let content = "[link](./README.md#)";
assert_eq!(
convert_links_to_readme_files(&content),
"[link](./index.md#)"
);

let content = "[link](https://some.domain/README.md)";
assert_eq!(convert_links_to_readme_files(&content), content);
}
}