Skip to content

ci: Upgrade to the macos-15 and windows-2025 runners #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
name: Clippy on ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-24.04, macos-15, windows-2022]
os: [ubuntu-24.04, macos-15, windows-2025]
runs-on: ${{ matrix.os }}
timeout-minutes: 10
steps:
Expand All @@ -56,7 +56,7 @@ jobs:
strategy:
matrix:
toolchain: [stable, nightly, 1.63.0]
os: [ubuntu-24.04, macos-15, windows-2022]
os: [ubuntu-24.04, macos-15, windows-2025]
include:
- toolchain: beta
os: ubuntu-24.04
Expand Down Expand Up @@ -89,7 +89,7 @@ jobs:
# Remove `-Dwarnings` at the MSRV since lints may be different
export RUSTFLAGS=""
# Remove `ctest-next` which uses the 2024 edition
perl -i -ne 'print unless /"ctest-(next|test)",/' Cargo.toml
perl -i -ne 'print unless /"ctest-next",/' Cargo.toml
fi

./ci/verify-build.sh
Expand Down Expand Up @@ -122,19 +122,19 @@ jobs:
- target: aarch64-apple-darwin
os: macos-15
- target: x86_64-pc-windows-gnu
os: windows-2022
os: windows-2025
env:
ARCH_BITS: 64
ARCH: x86_64
- target: x86_64-pc-windows-msvc
os: windows-2022
os: windows-2025
# FIXME: It currently causes segfaults.
#- target: i686-pc-windows-gnu
# env:
# ARCH_BITS: 32
# ARCH: i686
- target: i686-pc-windows-msvc
os: windows-2022
os: windows-2025
runs-on: ${{ matrix.os }}
timeout-minutes: 25
env:
Expand Down Expand Up @@ -320,7 +320,7 @@ jobs:
- name: Install Rust
run: rustup update "$MSRV" --no-self-update && rustup default "$MSRV"
- name: Remove edition 2024 crates
run: perl -i -ne 'print unless /"ctest-(next|test)",/' Cargo.toml
run: perl -i -ne 'print unless /"ctest-next",/' Cargo.toml
- uses: Swatinem/rust-cache@v2
- run: cargo build -p ctest

Expand Down
19 changes: 0 additions & 19 deletions ci/create-artifacts.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,23 +42,4 @@ def main():


if __name__ == "__main__":
# FIXME(ci): remove after the bump to windoes-2025 GHA images
# Python <= 3.9 does not support the very helpful `root_dir` argument,
# and that is the version used by the Windows GHA images. Rather than
# using setup-python or doing something in the CI script, just find
# the newer version and relaunch if this happens to be run with an old
# version.
try:
glob("", root_dir="")
except TypeError:
if os.environ.get("CI") is None:
sys.exit(1)

# Find the next 3.1x Python version
dirs = sorted(list(Path(r"C:\hostedtoolcache\windows\Python").iterdir()))
usepy = next(x for x in dirs if r"\3.1" in str(x))
py = usepy.joinpath(r"x64\python.exe")
print(f"relaunching with {py}")
os.execvp(py, [__file__] + sys.argv)

main()
3 changes: 0 additions & 3 deletions src/windows/gnu/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ cfg_if! {
}
}

pub const L_tmpnam: c_uint = 14;
pub const TMP_MAX: c_uint = 0x7fff;

// stdio file descriptor numbers
pub const STDIN_FILENO: c_int = 0;
pub const STDOUT_FILENO: c_int = 1;
Expand Down
3 changes: 3 additions & 0 deletions src/windows/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,9 @@ pub const SIG_GET: crate::sighandler_t = 2;
pub const SIG_SGE: crate::sighandler_t = 3;
pub const SIG_ACK: crate::sighandler_t = 4;

pub const L_tmpnam: c_uint = 260;
pub const TMP_MAX: c_uint = 0x7fff_ffff;

#[cfg_attr(feature = "extra_traits", derive(Debug))]
pub enum FILE {}
impl Copy for FILE {}
Expand Down
3 changes: 0 additions & 3 deletions src/windows/msvc/mod.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
use crate::prelude::*;

pub const L_tmpnam: c_uint = 260;
pub const TMP_MAX: c_uint = 0x7fff_ffff;

// POSIX Supplement (from errno.h)
// This particular error code is only currently available in msvc toolchain
pub const EOTHER: c_int = 131;
Expand Down
Loading