Skip to content

Enable statx on musl-libc #3976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable statx on musl-libc #3976

wants to merge 1 commit into from

Conversation

neuschaefer
Copy link
Contributor

@neuschaefer neuschaefer commented Oct 16, 2024 •
edited
Loading

Description

This PR adds the statx syscall on Linux/musl, which is available since musl 1.2.5.

Closes: #3972

This PR is currently blocked by #3791 and #3978.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@neuschaefer neuschaefer force-pushed the statx branch 24 times, most recently from 05343c1 to 48e8413 Compare October 16, 2024 17:24
@tgross35
Copy link
Contributor

tgross35 commented Nov 6, 2024

@rustbot blocked

@bors
Copy link
Contributor

bors commented Nov 16, 2024

☔ The latest upstream changes (presumably #4042) made this pull request unmergeable. Please resolve the merge conflicts.

@neuschaefer neuschaefer force-pushed the statx branch 4 times, most recently from c6ed9b3 to 93a3c59 Compare November 24, 2024 01:48
@bors
Copy link
Contributor

bors commented Nov 27, 2024

☔ The latest upstream changes (presumably #4132) made this pull request unmergeable. Please resolve the merge conflicts.

@1715173329 1715173329 mentioned this pull request Jun 28, 2025
Closed
@tgross35
Copy link
Contributor

tgross35 commented Jul 3, 2025

We now have the config musl_v1_2_3 that you could gate this under

@neuschaefer
Enable statx on musl-libc
6a9fa70 
Version 1.2.5 of musl-libc added support for the statx system call[1].

[1]: https://musl.libc.org/releases.html
neuschaefer
neuschaefer commented Jul 3, 2025
View reviewed changes
src/unix/linux_like/mod.rs Outdated
pub stx_atomic_write_unit_max: crate::__u32,
pub stx_atomic_write_segments_max: crate::__u32,
__statx_pad2: [crate::__u32; 1],
__statx_pad3: [crate::__u64; 9],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm dropping the new constant for now, as they seem likely to cause more headaches

@neuschaefer neuschaefer marked this pull request as ready for review July 4, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JohnTitor JohnTitor

Labels
O-android O-gnu O-linux O-linux-like O-unix S-blocked S-waiting-on-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

statx using the musl libc
5 participants
@neuschaefer @rustbot @tgross35 @bors @JohnTitor