upgrade zlib-rs to version 0.5.1
#490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
reviewed
Jun 7, 2025
| @@ -468,7 +468,7 @@ mod c_backend { | |||
| #[cfg(feature = "zlib-ng")] | |||
| const ZLIB_VERSION: &str = "2.1.0.devel\0"; | |||
| #[cfg(all(not(feature = "zlib-ng"), feature = "zlib-rs"))] | |||
| const ZLIB_VERSION: &str = "1.3.0-zlib-rs-0.5.0\0"; | |||
| const ZLIB_VERSION: &str = "1.3.0-zlib-rs-0.5.1\0"; | |||
There was a problem hiding this comment.
I just realised that if it wasn't for this string, flate2 wouldn't need a release if zlib-rs increases its patch level.
Something I am wondering about is if this lock-step releasing is truly required for everything to work?
There was a problem hiding this comment.
As far as I can tell, the only thing that zlib-rs actually cares about is that the first byte of the string is a '1' character.
|
A new release is now available: https://github.com/rust-lang/flate2-rs/releases/tag/1.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/trifectatechfoundation/zlib-rs/releases/tag/v0.5.1
Fixes some minor bugs and improves performance.