Skip to content

Fix links color #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile-gui-tests
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ RUN mkdir out
# https://github.com/puppeteer/puppeteer/issues/375
#
# We also specify the version in case we need to update it to go around cache limitations.
RUN npm install -g browser-ui-test@0.21.0 --unsafe-perm=true
RUN npm install -g browser-ui-test@0.21.1 --unsafe-perm=true

EXPOSE 3000

Expand Down
17 changes: 17 additions & 0 deletions gui-tests/links-color.goml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// Checks that the links have the expected color.
go-to: |DOC_PATH|
show-text: true

// First we enforce the theme to ensure we're testing in the right conditions.
set-local-storage: {"rustdoc-theme": "light"}
reload:

// The "Recent releases" and the feed icon should have the default color.
assert-css: ("//a[@href='/releases']", {"color": "#000"})
assert-css: ("//a[@href='/releases/feed']", {"color": "#000"})
// The release links should be different.
assert-css: ("li a.release .name", {"color": "#4d76ae"}, ALL)

go-to: |DOC_PATH| + "/crate/sysinfo/0.23.5/builds"
// The builds link color should have the default color.
assert-css: ("li a.release > div", {"color": "#000"}, ALL)
4 changes: 4 additions & 0 deletions templates/style/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,10 @@ div.recent-releases-container {
padding: 0.4em $search-result-right-left-padding;
color: var(--color-standard);

a:not(.normal) {
color: var(--color-standard)
}

@media #{$media-lg} {
padding: 0.4em 0;
margin: 0 1em;
Expand Down
Loading