Skip to content

Move about page tabs system in header dropdown #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2025
Merged

Move about page tabs system in header dropdown #2857

merged 3 commits into from
Jul 3, 2025

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jul 2, 2025 •
edited
Loading

It now looks like this:

image

It greatly simplifies the about pages and it also directly gives access to all pages without needing to go to the about pages index page.

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner July 2, 2025 13:39
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jul 2, 2025
@GuillaumeGomez GuillaumeGomez force-pushed the about-pages-menu branch 3 times, most recently from 8e35713 to 2492432 Compare July 2, 2025 15:46
syphar
syphar reviewed Jul 3, 2025
View reviewed changes
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we horizontally align the text in the dropdown menu?

@GuillaumeGomez
Copy link
Member Author

Even simpler, added an icon:

image

@syphar
Copy link
Member

syphar commented Jul 3, 2025

Even simpler, added an icon:

image

I meant that I expected the text to be aligned too. no matter the icon size

@GuillaumeGomez
Copy link
Member Author

Ah I see. Done:

image

syphar
syphar approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

testing this I also saw there are some discrepancies where the queue is full width, while other release-lists are not.

Also I feel now the documentation pages might benefit from a sidebar with a menu of the sections. But that's separate.

@syphar syphar merged commit 14c7543 into rust-lang:master Jul 3, 2025
9 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jul 3, 2025
@GuillaumeGomez
Copy link
Member Author

testing this I also saw there are some discrepancies where the queue is full width, while other release-lists are not.

Ah? Do you have a screenshot? Might be simpler to open an issue and ping me on it. :)

@GuillaumeGomez GuillaumeGomez deleted the about-pages-menu branch July 3, 2025 10:56
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syphar syphar syphar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeGomez @syphar