Add an API route for admins to assess crates #11528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connects to #10387. This API route, under `/private/` rather than `v1`, will make it a lot easier to assess whether crates contain useful functionality or are squatting. This is only the backend; some of the functionality described in the issue will be frontend-only, but I wanted to get the API in first. The API route will only return data if the currently authenticated user is an admin. This is important because the crate owner's verified email address is part of the returned data so that the admin can contact the owner if necessary. Another reason this route is limited to admins is that some of the queries may be slow.
Turbo87
approved these changes
Jul 6, 2025
Turbo87
added
C-internal 🔧
Which is only true if all versions are yanked, because otherwise a different version would be the default
…unverified emails
|
Ok I added a bunch of little commits that should hopefully be easy-ish to review one-by-one, and i think addressed everything! great suggestions, thank you!! |
Turbo87
approved these changes
Jul 9, 2025
Turbo87
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #10387.
This API route, under
/private/rather thanv1, will make it a lot easier to assess whether crates contain useful functionality or are squatting.This is only the backend; some of the functionality described in the issue will be frontend-only, but I wanted to get the API in first.
The API route will only return data if the currently authenticated user is an admin. This is important because the crate owner's verified email address is part of the returned data so that the admin can contact the owner if necessary.
Another reason this route is limited to admins is that some of the queries may be slow.