Skip to content

Added crate ID for background jobs #11455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 35 additions & 23 deletions src/bin/crates-admin/delete_crate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -83,38 +83,50 @@ pub async fn run(opts: Opts) -> anyhow::Result<()> {
let available_at = now + chrono::TimeDelta::hours(opts.availability_delay);

for name in &crate_names {
if let Some(crate_info) = existing_crates.iter().find(|info| info.name == *name) {
let id = crate_info.id;

let deleted_crate = NewDeletedCrate::builder(name)
.created_at(&crate_info.created_at)
.deleted_at(&now)
.deleted_by(deleted_by.id)
.maybe_message(opts.message.as_deref())
.available_at(&available_at)
.build();

info!("{name}: Deleting crate from the database…");
let result = conn
.transaction(|conn| delete_from_database(conn, id, deleted_crate).scope_boxed())
.await;

if let Err(error) = result {
warn!(%id, "{name}: Failed to delete crate from the database: {error}");
let crate_id =
if let Some(crate_info) = existing_crates.iter().find(|info| info.name == *name) {
let id = crate_info.id;

let deleted_crate = NewDeletedCrate::builder(name)
.created_at(&crate_info.created_at)
.deleted_at(&now)
.deleted_by(deleted_by.id)
.maybe_message(opts.message.as_deref())
.available_at(&available_at)
.build();

info!("{name}: Deleting crate from the database…");
let result = conn
.transaction(|conn| delete_from_database(conn, id, deleted_crate).scope_boxed())
.await;

if let Err(error) = result {
warn!(%id, "{name}: Failed to delete crate from the database: {error}");
};

Some(id)
} else {
info!("{name}: Skipped missing crate");

None
};
} else {
info!("{name}: Skipped missing crate");
};

info!("{name}: Enqueuing background jobs…");
let git_index_job = jobs::SyncToGitIndex::new(name);
let sparse_index_job = jobs::SyncToSparseIndex::new(name);
let delete_from_storage_job = jobs::DeleteCrateFromStorage::new(name.into());
let delete_from_storage_job = async |conn: &mut AsyncPgConnection| {
if let Some(crate_id) = crate_id {
jobs::DeleteCrateFromStorage::new(name.into(), crate_id)
.enqueue(conn)
.await?;
}
Ok(())
};

if let Err(error) = tokio::try_join!(
git_index_job.enqueue(&mut conn),
sparse_index_job.enqueue(&mut conn),
delete_from_storage_job.enqueue(&mut conn),
delete_from_storage_job(&mut conn),
) {
warn!("{name}: Failed to enqueue background job: {error}");
}
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/krate/delete.rs
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ pub async fn delete_crate(

let git_index_job = jobs::SyncToGitIndex::new(&krate.name);
let sparse_index_job = jobs::SyncToSparseIndex::new(&krate.name);
let delete_from_storage_job = jobs::DeleteCrateFromStorage::new(path.name);
let delete_from_storage_job = jobs::DeleteCrateFromStorage::new(path.name, krate.id);

tokio::try_join!(
git_index_job.enqueue(conn),
Expand Down
8 changes: 6 additions & 2 deletions src/worker/jobs/delete_crate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,15 @@ use tracing::info;
#[derive(Serialize, Deserialize)]
pub struct DeleteCrateFromStorage {
name: String,
crate_id: Option<i32>,
}

impl DeleteCrateFromStorage {
pub fn new(name: String) -> Self {
Self { name }
pub fn new(name: String, crate_id: i32) -> Self {
Self {
name,
crate_id: Some(crate_id),
}
}
}

Expand Down