Add flags method to cc::Build for adding multiple flags
#1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodyXu
requested changes
May 7, 2025
There was a problem hiding this comment.
Thanks!
Should we have some tests?
IMO having a no_run example is enough
Should the flags method also handle the case where a single string of flags (e.g., "flag1 flag2") is passed and split it into individual flags?
No that should not be part of this function.
Having another function for this is acceptable, as we already do that kinds of parsing for environment variables.
NobodyXu
requested changes
May 7, 2025
Co-authored-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
NobodyXu
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1465. Thank you @NobodyXu.
My concerns:
flagsmethod also handle the case where a single string of flags (e.g.,"flag1 flag2") is passed and split it into individual flags? Alternatively, should we delegate this responsibility to an external crate like shell-words to handle more complex cases like quoted strings with spaces?