[Work in Progress] feat: Pull out lock file schema to cargo-util-schema
#15742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-dependency-resolution
secona
force-pushed
the
cargo-util-schemas-lockfile
branch
from
5233dbe to
30ea639
Compare
secona
changed the title
NormalizedResolvecargo-util-schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
I'm currently working on cargo-plumbing commands, especially the read lockfile functionality. Currently, the
EncodableResolvestruct is quite difficult to manage with from a 3rd party perspective. This change attempts to moveEncodableResolve-related structs tocargo-util-schemasand make it less intertwined with serialization aspect of lockfiles.Opening as draft PR as this is still a work in progress. I'd love to hear some feedbacks!
See discussion for
cargo-plumbing: crate-ci/cargo-plumbing#35cc @epage
How to test and review this PR?