Skip to content

Commit 84976cd

Browse files
committed
Auto merge of #13287 - weihanglo:sort-summaries, r=Eh2406
fix(resolver): do not panic when sorting empty summaries
2 parents bf27f90 + 6cee9bf commit 84976cd

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

src/cargo/core/resolver/version_prefs.rs

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ impl VersionPreferences {
125125
VersionOrdering::MinimumVersionsFirst => cmp,
126126
}
127127
});
128-
if first_version.is_some() {
128+
if first_version.is_some() && !summaries.is_empty() {
129129
let _ = summaries.split_off(1);
130130
}
131131
}
@@ -283,4 +283,13 @@ mod test {
283283
.to_string()
284284
);
285285
}
286+
287+
#[test]
288+
fn test_empty_summaries() {
289+
let vp = VersionPreferences::default();
290+
let mut summaries = vec![];
291+
292+
vp.sort_summaries(&mut summaries, Some(VersionOrdering::MaximumVersionsFirst));
293+
assert_eq!(summaries, vec![]);
294+
}
286295
}

0 commit comments

Comments
 (0)