Skip to content

Commit 6cee9bf

Browse files
committed
fix(resolver): do not panic when sorting empty summaries
1 parent c677f73 commit 6cee9bf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/cargo/core/resolver/version_prefs.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ impl VersionPreferences {
125125
VersionOrdering::MinimumVersionsFirst => cmp,
126126
}
127127
});
128-
if first_version.is_some() {
128+
if first_version.is_some() && !summaries.is_empty() {
129129
let _ = summaries.split_off(1);
130130
}
131131
}
@@ -284,12 +284,12 @@ mod test {
284284
);
285285
}
286286

287-
#[should_panic = "`at` split index (is 1) should be <= len (is 0)"]
288287
#[test]
289288
fn test_empty_summaries() {
290289
let vp = VersionPreferences::default();
291290
let mut summaries = vec![];
292291

293292
vp.sort_summaries(&mut summaries, Some(VersionOrdering::MaximumVersionsFirst));
293+
assert_eq!(summaries, vec![]);
294294
}
295295
}

0 commit comments

Comments
 (0)