refactor: rename global client to repo loader

Author: vohoanglong0107

src/bors/context.rs

@@ -3,20 +3,20 @@ use arc_swap::ArcSwap;
 use crate::{bors::command::CommandParser, database::DbClient, github::GithubRepoName};
 use std::{collections::HashMap, sync::Arc};
 
-use super::{GlobalClient, RepositoryClient, RepositoryState};
+use super::{RepositoryClient, RepositoryLoader, RepositoryState};
 
 pub struct BorsContext<Client: RepositoryClient> {
     pub parser: CommandParser,
     pub db: Arc<dyn DbClient>,
-    pub global_client: Arc<dyn GlobalClient<Client>>,
+    pub repository_loader: Arc<dyn RepositoryLoader<Client>>,
     pub repositories: Arc<ArcSwap<HashMap<GithubRepoName, Arc<RepositoryState<Client>>>>>,
 }
 
 impl<Client: RepositoryClient> BorsContext<Client> {
     pub async fn new(
         parser: CommandParser,
         db: Arc<dyn DbClient>,
-        global_client: Arc<dyn GlobalClient<Client>>,
+        global_client: Arc<dyn RepositoryLoader<Client>>,
     ) -> anyhow::Result<Self> {
         // this unwrap is making me nervous, but if lhe repos loading
         // fails we might as well restart the bot
@@ -25,7 +25,7 @@ impl<Client: RepositoryClient> BorsContext<Client> {
         Ok(Self {
             parser,
             db,
-            global_client,
+            repository_loader: global_client,
             repositories,
         })
     }

src/bors/handlers/mod.rs

@@ -123,7 +123,7 @@ pub async fn handle_bors_global_event<Client: RepositoryClient>(
         BorsGlobalEvent::InstallationsChanged => {
             let span = tracing::info_span!("Repository reload").entered();
 
-            match ctx.global_client.load_repositories().await {
+            match ctx.repository_loader.load_repositories().await {
                 Ok(repos) => {
                     ctx.repositories.store(Arc::new(repos));
                 }

src/bors/mod.rs

@@ -74,7 +74,7 @@ pub trait RepositoryClient: Send + Sync {
 /// Temporary trait to sastify the test mocking.
 /// TODO: Remove this trait once we move to mock REST API call.
 #[async_trait]
-pub trait GlobalClient<Client: RepositoryClient>: Send + Sync {
+pub trait RepositoryLoader<Client: RepositoryClient>: Send + Sync {
     /// Load state of repositories.
     async fn load_repositories(
         &self,

src/github/api/client.rs

@@ -9,7 +9,7 @@ use tracing::log;
 
 use crate::bors::event::PullRequestComment;
 use crate::bors::{
-    CheckSuite, CheckSuiteStatus, Comment, GlobalClient, RepositoryClient, RepositoryState,
+    CheckSuite, CheckSuiteStatus, Comment, RepositoryClient, RepositoryLoader, RepositoryState,
 };
 use crate::config::{RepositoryConfig, CONFIG_FILE_PATH};
 use crate::github::api::base_github_html_url;
@@ -271,7 +271,7 @@ impl RepositoryClient for GithubRepositoryClient {
 }
 
 #[async_trait]
-impl GlobalClient<GithubRepositoryClient> for Octocrab {
+impl RepositoryLoader<GithubRepositoryClient> for Octocrab {
     async fn load_repositories(
         &self,
     ) -> anyhow::Result<HashMap<GithubRepoName, Arc<RepositoryState<GithubRepositoryClient>>>> {

src/tests/state.rs

@@ -19,7 +19,7 @@ use crate::bors::{
     handle_bors_global_event, handle_bors_repository_event, BorsContext, CheckSuite, CommandParser,
     Comment, RepositoryState,
 };
-use crate::bors::{GlobalClient, RepositoryClient};
+use crate::bors::{RepositoryClient, RepositoryLoader};
 use crate::config::RepositoryConfig;
 use crate::database::{DbClient, WorkflowStatus};
 use crate::github::{
@@ -260,7 +260,7 @@ impl ClientBuilder {
 }
 
 #[async_trait]
-impl GlobalClient<Arc<TestRepositoryClient>> for Arc<TestRepositoryClient> {
+impl RepositoryLoader<Arc<TestRepositoryClient>> for Arc<TestRepositoryClient> {
     async fn load_repositories(
         &self,
     ) -> anyhow::Result<HashMap<GithubRepoName, Arc<TestRepositoryState>>> {