refactor: return result for borscontext::new

Author: vohoanglong0107

src/bin/bors.rs

@@ -75,11 +75,13 @@ fn try_main(opts: Opts) -> anyhow::Result<()> {
         create_github_client(opts.app_id.into(), opts.private_key.into_bytes().into())
     })?;
 
-    let ctx = runtime.block_on(BorsContext::new(
-        CommandParser::new(opts.cmd_prefix),
-        Arc::new(db),
-        Arc::new(client),
-    ));
+    let ctx = runtime
+        .block_on(BorsContext::new(
+            CommandParser::new(opts.cmd_prefix),
+            Arc::new(db),
+            Arc::new(client),
+        ))
+        .context("Cannot initialize bors context")?;
     let (repository_tx, global_tx, bors_process) = create_bors_process(ctx);
 
     let refresh_tx = global_tx.clone();

src/bors/context.rs

@@ -17,16 +17,16 @@ impl<Client: RepositoryClient> BorsContext<Client> {
         parser: CommandParser,
         db: Arc<dyn DbClient>,
         global_client: Arc<dyn GlobalClient<Client>>,
-    ) -> Self {
+    ) -> anyhow::Result<Self> {
         // this unwrap is making me nervous, but if lhe repos loading
         // fails we might as well restart the bot
-        let repositories = global_client.load_repositories().await.unwrap();
+        let repositories = global_client.load_repositories().await?;
         let repositories = Arc::new(ArcSwap::new(Arc::new(repositories)));
-        Self {
+        Ok(Self {
             parser,
             db,
             global_client,
             repositories,
-        }
+        })
     }
 }

src/tests/state.rs

@@ -72,7 +72,8 @@ impl TestBorsState {
                 Arc::clone(&self.db) as Arc<dyn DbClient>,
                 Arc::new(self.default_client.clone()),
             )
-            .await,
+            .await
+            .unwrap(),
         );
         match event {
             BorsEvent::Repository(event) => {