build(core): allow windows-targets 0.53.0
#694
Conversation
ErichDonGubler
force-pushed
the
windows-targets-0.53
branch
from
6b3e731 to
43e7db9
Compare
|
This PR is effectively ready for review, minus dependencies. A local |
|
Looks like CI is indeed happy? Is this still a draft? poking @ChrisDenton |
ErichDonGubler
force-pushed
the
windows-targets-0.53
branch
from
43e7db9 to
ce6b657
Compare
|
|
| @@ -39,7 +39,7 @@ cpp_demangle = { default-features = false, version = "0.4.0", optional = true, f | |||
| ] } | |||
|
|
|||
| [target.'cfg(any(windows, target_os = "cygwin"))'.dependencies] | |||
| windows-targets = "0.52.6" | |||
| windows-targets = ">=0.52.6,<0.54.0" | |||
There was a problem hiding this comment.
Driveby note; this is a pretty unusual version spec, it should come with a comment explaining what's going on
There was a problem hiding this comment.
Added a comment in the latest rebased commit.
TBH, I'm not sure what commentary to add besides "this is what the version spec. does". Did you have more in mind?
ErichDonGubler
force-pushed
the
windows-targets-0.53
branch
from
ce6b657 to
3ae9df5
Compare
|
The Test (windows-latest, stable-i686-msvc) job is failing, but I'm not sure why, or how exactly to debug this. I don't have any 32-bit machines. 😅 |
Hard dependency on nagisa/rust_libloading#169.