Draw attention to Position::Only in docs #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottmcm
approved these changes
Jul 6, 2025
| First, | ||
| /// This is neither the first nor the last element. | ||
| Middle, | ||
| /// This is the last element. | ||
| /// This is the last element, and there was more than one element. | ||
| Last, | ||
| /// This is the only element. |
There was a problem hiding this comment.
Maybe to parallel,
Suggested change
| /// This is the only element. | |
| /// This is the only element, and thus both the first *and* the last. |
There was a problem hiding this comment.
I've intentionally left it unsaid, because even though it's first or last, it's not First nor Last (a custom PartialEq implementation could make it possible for Only to equal First and Last too, but that's not the case).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1043 +/- ##
==========================================
- Coverage 94.38% 94.26% -0.13%
==========================================
Files 48 50 +2
Lines 6665 6226 -439
==========================================
- Hits 6291 5869 -422
+ Misses 374 357 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phimuemue
approved these changes
Jul 7, 2025
Merged
via the queue into
rust-itertools:master
with commit Jul 7, 2025
b40b06b
9 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just documentation improvements from #1042 without API changes.