-
Notifications
You must be signed in to change notification settings - Fork 178
Improve Spelling #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Spelling #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Sweet! Do want a changelog entry? |
I don't think it is necessary, thanks! |
@gibbz00 can you add the following configuration: include:
# Nightly is only for reference and allowed to fail
- toolchain: nightly
experimental: true To |
Alternatively, we can fix the nightly clippy lints, but it might lead to an MSRV bump, which is not always desirable... |
Head branch was pushed to by a user without write access
Guessing this is about #299? Went ahead anyway, take it you're ready to resolve the conflicts there 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
By the way, Nightly Clippy is quite a nightmare, we should seriously consider removing it from the CI.
f0ed17b
I personally enjoy running things on nightly 😅 Granted, I limit myself to these in [workspace.lints.rust]
missing_docs = "warn"
unused_must_use = "deny" Perhaps it's more a result of running CI with |
CI typos workflow is more so an example of how it could be done. Completely OK with dropping that commit 😊