Skip to content

Improve Spelling #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

Improve Spelling #316

merged 3 commits into from
Jun 30, 2025

Conversation

gibbz00
Copy link
Contributor

@gibbz00 gibbz00 commented Jun 29, 2025

CI typos workflow is more so an example of how it could be done. Completely OK with dropping that commit 😊

@gibbz00 gibbz00 requested a review from a team as a code owner June 29, 2025 08:06
romancardenas
romancardenas previously approved these changes Jun 29, 2025
Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@gibbz00
Copy link
Contributor Author

gibbz00 commented Jun 29, 2025

Sweet! Do want a changelog entry?

@romancardenas
Copy link
Contributor

I don't think it is necessary, thanks!

@romancardenas romancardenas enabled auto-merge June 30, 2025 08:24
@romancardenas
Copy link
Contributor

@gibbz00 can you add the following configuration:

    include:
          # Nightly is only for reference and allowed to fail
          - toolchain: nightly
            experimental: true

To clippy.yaml for the clippy-riscv-rt job on the matrix section?

@romancardenas
Copy link
Contributor

Alternatively, we can fix the nightly clippy lints, but it might lead to an MSRV bump, which is not always desirable...

auto-merge was automatically disabled June 30, 2025 08:38

Head branch was pushed to by a user without write access

@gibbz00
Copy link
Contributor Author

gibbz00 commented Jun 30, 2025

Alternatively, we can fix the nightly clippy lints, but it might lead to an MSRV bump, which is not always desirable...

Guessing this is about #299? Went ahead anyway, take it you're ready to resolve the conflicts there 😅

Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

By the way, Nightly Clippy is quite a nightmare, we should seriously consider removing it from the CI.

@romancardenas romancardenas added this pull request to the merge queue Jun 30, 2025
Merged via the queue into rust-embedded:master with commit f0ed17b Jun 30, 2025
274 of 278 checks passed
@gibbz00
Copy link
Contributor Author

gibbz00 commented Jun 30, 2025

By the way, Nightly Clippy is quite a nightmare, we should seriously consider removing it from the CI.

I personally enjoy running things on nightly 😅 Granted, I limit myself to these in Cargo.toml

[workspace.lints.rust]
missing_docs = "warn"
unused_must_use = "deny"

Perhaps it's more a result of running CI with CLIPPY_PARAMS: -W clippy::all -W clippy::pedantic -W clippy::nursery -W clippy::cargo that's causing problems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants