Skip to content

Fix De105Key layout: add missing AltGr keys #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025

Conversation

rsahwe
Copy link
Contributor

@rsahwe rsahwe commented May 14, 2025

All of the keys added here are both on Wikipedia and on kbdlayout.info.
Before this it is impossible to input even [ on the De105Key layout.

Copy link
Contributor

@jonathanpallant jonathanpallant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathanpallant
Copy link
Contributor

Please could you add a line to https://github.com/rust-embedded-community/pc-keyboard/blob/main/CHANGELOG.md describing the change?

@rsahwe
Copy link
Contributor Author

rsahwe commented May 14, 2025

Do I need to add more info on the change or is this enough?

@jonathanpallant
Copy link
Contributor

Perhaps mention "Add missing Alt-Gr combinations" or something? So if people think "Huh, I have keys missing from the DE105 layout in my version" it's obvious from the CHANGELOG that this next release will fix their issue.

@jonathanpallant jonathanpallant merged commit d532e8a into rust-embedded-community:main May 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants