Skip to content

Change struct names to match exported name #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

newAM
Copy link
Contributor

@newAM newAM commented Apr 4, 2025

This helps readability to distinguish between the Hasher trait, and the structs that implement the Hasher trait.

This helps readability to distinguish between the Hasher trait, and
the structs that implement the Hasher trait.
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thanks.
Could you add an entry to the changelog?

@newAM
Copy link
Contributor Author

newAM commented Apr 4, 2025

This doesn't have a user-visible change, the exported names haven't changed. Should I still update the changelog?

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry I missed that. It looks good to me as it is. Thanks!

@eldruin eldruin merged commit 037abd5 into rust-embedded-community:main Apr 4, 2025
5 checks passed
@newAM newAM deleted the hasher-rename branch April 4, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants