Skip to content

Explicitly set RecoveryId value #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Jun 12, 2025

At the moment its implicit in the name, make it explicit.

Close: #777

@apoelstra
Copy link
Member

Can you rebase and format this?

At the moment its implicit in the name, make it explicit.
@tcharding tcharding force-pushed the 06-12-recid-explicit-values branch from 631e595 to 6ed3a58 Compare June 25, 2025 00:46
@tcharding tcharding marked this pull request as ready for review June 25, 2025 00:46
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6ed3a58; successfully ran local tests

@apoelstra apoelstra merged commit 5e622c3 into rust-bitcoin:master Jun 26, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign values to RecoveryId
2 participants