Skip to content

Fix getting parity from keypair in fuzzing #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

real-or-random
Copy link
Collaborator

This also enables a test that was failung due to the parity bug.

This also enables a test that was failung due to the parity bug.
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend!

ACK f419fe8

@elichai
Copy link
Member

elichai commented Jun 16, 2022

Could you explain why in other places it does check the 32'nd byte but here the 64?
Thanks

@real-or-random
Copy link
Collaborator Author

@elichai
See #435 (comment)

Or are you saying there's another place where it should be changed to 64? Do you want me to add a comment or change the commit message to explain this?

@elichai
Copy link
Member

elichai commented Jun 16, 2022

That was exactly the context I've missed, Thanks!

Copy link
Member

@elichai elichai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f419fe8

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f419fe8

@apoelstra apoelstra merged commit 1c4dd0d into rust-bitcoin:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants