Skip to content

Fix libdeflate feature selection #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

juliangehring
Copy link
Contributor

@juliangehring juliangehring commented Jun 22, 2020

The libdeflate feature (added in #189) isn't currently propagated and the feature gets silently ignored during build. Fixing the feature names and dependencies addresses this, and also ensures that the feature-specific tests are correctly ignored.

If someone knows a good way to automatically test that the correct deflate library is included, I'd be happy to add this as well.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 143906896

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.591%

Totals Coverage Status
Change from base Build 143771216: 0.0%
Covered Lines: 10172
Relevant Lines: 10986

💛 - Coveralls

@brainstorm
Copy link
Member

Good catch @juliangehring, thanks!

If someone knows a good way to automatically test that the correct deflate library is included, I'd be happy to add this as well.

That should be tackled by libdeflate-sys itself afaik (it'll error out if not found or sth else is wrong)? Regardless, let's merge this PR, looks fine and seems to work now (local test), thanks again!

@brainstorm brainstorm merged commit a8491a1 into rust-bio:master Jun 23, 2020
@brainstorm
Copy link
Member

Oh, sorry, you meant testing as in use libflate and assert some result on tests?

@juliangehring juliangehring deleted the libdeflate branch August 16, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants