Removing compiler build and using rustup
#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to fix tests, and pass flag to stop binary being built. `Makefile` needs to be stripped down too,
dkcumming
changed the title
rustup.rustup
jberthold
approved these changes
Jan 30, 2025
Makefile
Outdated
Comment on lines
41
to
44
| build: | ||
| cargo build ${RELEASE_FLAG} | ||
|
|
||
| clean: |
There was a problem hiding this comment.
Should we maybe keep build, and update clean to do the right thing?
Comment on lines
-97
to
-102
| generate_ui_tests: | ||
| mkdir -p "${RUST_DIR}"/tests | ||
| cd "${RUST_SRC}"; ./get_runpass.sh tests/ui > "${RUST_DIR}"/tests_ui_sources | ||
| -cd "${RUST_SRC}"; ./ui_compiletest.sh "${RUST_SRC}" "${RUST_DIR}"/tests/ui/upstream "${RUST_DIR}"/tests_ui_sources --pass check --force-rerun 2>&1 > "${RUST_DIR}"/tests_ui_upstream.log | ||
| -cd "${RUST_SRC}"; RUST_BIN="${PWD}"/run.sh ./ui_compiletest.sh "${RUST_SRC}" "${RUST_DIR}"/tests/ui/smir "${RUST_DIR}"/tests_ui_sources --pass check --force-rerun 2>&1 > "${RUST_DIR}"/tests_ui_smir.log | ||
|
|
There was a problem hiding this comment.
...reminds me I wanted to still check what exactly this is doing - more test programs and maybe more failure modes that we haven't seen... but we can still replicate this later.
There was a problem hiding this comment.
I think it is still accessible on our fork also could add an issue as a reminder there and backlog it
dkcumming
force-pushed
the
remove-building-repo
branch
from
9c99f1b to
008396b
Compare
dkcumming
added a commit
to runtimeverification/mir-semantics
that referenced
this pull request
Jan 31, 2025
Making mir-semantics compatible with PR where [smir-pretty uses rustup](runtimeverification/stable-mir-json#33) --------- Co-authored-by: devops <devops@runtimeverification.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing to use
rustupfor the Rust compiler now that we are not on our own fork.build.rsso that correct rust version is used with components installedMakefileneeds to be removedMakefileneeds to change to usecargomir-semantics(see this PR)Moved to future work:
cargo test? Could removeMakefileentirely thenstd lib