Skip to content

Conversation

petrubabalau
Copy link

@petrubabalau petrubabalau commented Oct 16, 2025

Description

This PR fixes an issue where the ReActOutputParser.parse method got stuck in a loop, repeatedly trying to parse the action step when the Answer: content contained Action:, resulting in the following error being raised:

workflows.errors.WorkflowRuntimeError: Max iterations of 20 reached! Either something went wrong, or you can increase the max iterations with `.run(.., max_iterations=...)

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

@petrubabalau petrubabalau force-pushed the enhance-react-output-parser branch from a62169f to 8c3e2e6 Compare October 16, 2025 12:19
@petrubabalau petrubabalau changed the title Enhance ReActOuputParser parsing Enhance ReActOuputParser to parse "Action:" in "Answer:" Oct 16, 2025
@petrubabalau petrubabalau changed the title Enhance ReActOuputParser to parse "Action:" in "Answer:" Fix ReActOutputParser getting stuck when "Answer:" contains "Action:" Oct 16, 2025
@petrubabalau petrubabalau marked this pull request as ready for review October 16, 2025 12:24
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant