Implement aget_nodes and adelete in PGVectorStore #18515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
GinkREAL
force-pushed
the
pgvector_aget_nodes
branch
2 times, most recently
from
d1bd0cd to
42bb8d1
Compare
GinkREAL
changed the title
|
Hold on. let me add an index on delete() first |
GinkREAL
force-pushed
the
pgvector_aget_nodes
branch
from
42bb8d1 to
6353049
Compare
|
BEFORE: AFTER: |
|
coverage is probably not working since most tests are skipped due to no postgres
|
logan-markewich
approved these changes
Apr 26, 2025
|
@logan-markewich I've realized a issue with the index. The delete operation is on Which one is the supposed one to be used? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements aget_nodes in PGVectorStore, previously this redirected to get_nodes causing a hidden sync operation in async paths.
Also implements adelete(), along with an index for ref_doc_id