Skip to content

exporter: Refactor force_root_clip_play to prevent force play from looping. #20927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AeroXuk
Copy link
Contributor

@AeroXuk AeroXuk commented Jul 5, 2025

Split from #20896.

  • Improve the --force-play feature to avoid restarting the timeline if it's already on the last frame.

@AeroXuk AeroXuk changed the title Refactor force_root_clip_play to prevent force play from looping. exporter: Refactor force_root_clip_play to prevent force play from looping. Jul 5, 2025
@kjarosh
Copy link
Member

kjarosh commented Jul 5, 2025

What's the purpose of it? Will that be even necessary after #20929 ?

@AeroXuk
Copy link
Contributor Author

AeroXuk commented Jul 5, 2025

What's the purpose of it? Will that be even necessary after #20929 ?

#20929 is adding a way to exit the export loop early if we reach the end.

Using the following senario, if you request it to export 200 frames of a 100 frame animation:

  • Without using --force-play, you will have frames 1 to 100, then 100 copies of the last frame.
  • Currently with --force-play, you will have frames 1 to 100 twice as it loops back to the begining.

The current looping behaviour with --force-play was not intended, the feature was intended for bypassing "click to play" or "click to continue" prompts. Adding this bugfix, would make the output match what happens if we aren't using the --force-play, once we reach the end we just keep outputting the last frame.

This then makes #20929 a bonus feature to also allow the exporter to stop after the last frame was exported, regardless of how many frames are requested.

@kjarosh kjarosh added exporter Issues related to the exporter tool A-other Area: Not covered by other area labels T-fix Type: Bug fix (in something that's supposed to work already) labels Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-other Area: Not covered by other area labels exporter Issues related to the exporter tool T-fix Type: Bug fix (in something that's supposed to work already)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants