Skip to content

Conversation

deivid-rodriguez
Copy link
Contributor

What was the end-user or developer problem that led to this PR?

Reviewing #8753 I'm seeing some unrelated style changes. I'd like to enforce a consistent style to get more focused PR diffs.

What is your fix for the problem, implemented in this PR?

Consistently use spaces around optional parameter values.

Make sure the following tasks are checked

Copy link
Contributor

@segiddins segiddins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this commit to the blame ignore list

@deivid-rodriguez
Copy link
Contributor Author

I generally draw the line around 400-500 net change, but other prefer smaller commits to be kept in there too, so let me add it!

@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/enable-spaces-around-optional-parameters branch from 04af6a0 to e81a4c1 Compare August 12, 2025 15:01
@deivid-rodriguez deivid-rodriguez merged commit dd55779 into master Aug 12, 2025
86 of 88 checks passed
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/enable-spaces-around-optional-parameters branch August 12, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants